[#18211] - User profile form is prepated twice in frontend. #18065
- Fixed in Code Base
- 18 Nov 2017
- Medium
- Build: staging
- # 18211
- Diff
- Denitz:user_profile_form_prepared_twice
- Pending continuous-integration/drone/pr this build is pending Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #18065
Steps to reproduce the issue
debug FieldsHelper::prepareForm() and see that it's launched twice in frontend:
Initially via PlgSystemFields->onContentPrepareForm event and see that it's launched twice in frontend.
Next FieldsHelper::prepareForm() is called again via UsersModelProfile::getForm()
Expected result
FieldsHelper::prepareForm() should be called once on user profile form display.
Actual result
Called twice
joomla-cms-bot
- | Category | ⇒ | Front End com_users |
| Status | New | ⇒ | Pending |
| Labels |
Added:
?
|
||
@stutteringp0et please mark your Test as successfully:
- open Issue Tracker
- Login with your github-Account
- Click on blue "Test this"-Button above Authors-Picture
- mark your Test as successfully
- hit "submit test result"
I have tested this item
Fields are still rendered, FieldsHelper::prepareForm is executed only once.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18211.
Done - looking forward to seeing this update in the next release. This issue was killing a feature of an extension I'm about to release.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18211.
I was playing around with this, and with the patch applied - the user profile fields are still rendered, and work correctly for the most part - but when I tried a "color" type field, the value doesn't get stored. It works for any other custom fields I create, but not the color type. I suspect this should be raised as a separate issue - but thought I should mention it here. When I try this on a vanilla 3.8.1 the color value is stored as expected.
@stutteringp0et can you please open a new Issue?
| Status | Pending | ⇒ | Ready to Commit |
RTC after two successful tests.
Can I raise an issue based on a PR that hasn't been merged yet?
Scratch my report about the color field type - I went through my settings and found that I forgot to give the user permission to change the value. Works fine now. No need for any action.
mbabker
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-11-18 15:53:39 |
| Closed_By | ⇒ | mbabker | |
| Labels |
Added:
?
|
||
Who can fix AppVeyor issue with
sqlitefor PHP 5.6?http://ci.joomla.org/joomla/joomla-cms/136 fails as well.