[#18194] - Modules - number not text
- Fixed in Code Base
- 5 Oct 2017
- Medium
- Build: staging
- # 18194
- Diff
- brianteeman:module-number
User tests: Successful: Unsuccessful:
Numerous options in the modules are for numbers but the xml field type is text. This pr changes them to the correct value of number.
This ensures that a user cannot enter a letter and only numbers. There are no b/c issues as only a numerical character could ever have worked and there is no change in the way the data is stored.
I spotted this when debugging a user's site where they put "five" in the count field instead of "5" and wondered why it didnt work. After this PR that isnt possible
joomla-cms-bot
- | Category | ⇒ | Modules Administration Front End |
| Status | New | ⇒ | Pending |
| Labels |
Added:
?
|
||
I have tested this item
Tested successfully on some modules, but unsuccessfully on modules/mod_articles_category/mod_articles_category
Additionally there could be used a filter="integer".
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18194.
You have for the Field count type="numbertext". It doenst work, of course. only a typo :) , but should not be merged.
This was not visible when I startet testing. So I can repeat the tests.
I have tested this item
Repeated some tests and inspection.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18194.
| Status | Pending | ⇒ | Ready to Commit |
RTC after two successful tests.
There is no rush to get this merged. Today I will be reviewing components and plugins for the same
See my comment here:
#18199 (comment)
See my reply #18199 (comment)
mbabker
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-10-05 12:15:12 |
| Closed_By | ⇒ | mbabker | |
| Labels |
Added:
?
|
||
Thanks
I have tested this item✅ successfully on af71c95
Code review
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18194.