[#1818] - Update stream.php
- Closed
- 6 May 2014
- Medium
- Build: master
- # 1818
- Diff
- bembelimen:patch-5
- Error default This pull request is targeted at the master branch. Pull requests should no longer be merged to master. Details
User tests: Successful: Unsuccessful:
Changed isSupported() method, now it returns false if allow_url_fopen is not set.
Testcase:
=> Allow fopen() and deactivate "allow_url_fopen" and activate CURL in your php.ini. Browse to the Joomla!-Updater:
=> Cannot use a stream transport when "allow_url_fopen" is disabled.
=> Apply patch
=> Try again, Joomla! should use CURL now
For a quarter line changed? Seriously? No there isn't
It's allright, no need for an issue.
Tracker created.
http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=31855&start=0
please test and comment there
| Status | New | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2013-12-06 04:06:00 |
Thanks @bembelimen!
This has not been committed to master
| Status | Closed | ⇒ | New |
@betweenbrain @infograf768 It went into staging.
I know. At this stage we may have to revert the merge to staging and merge in master. Suggest you discuss this with Michael.
@betweenbrain Not yet. Currently it's the other way around: master -> staging.
But we discussed and decided already to change it to staging -> master. Michael just didn't had the time yet to change Jenkins behavior as far as I know.
Sorry for the back and forth on this folks. While working on manually merging this, it seems that this may have already been solved with https://github.com/joomla/joomla-cms/pull/1619/files#diff-4f99848c581e6fad01897398d2332a63R228
| Status | New | ⇒ | Closed |
| Closed_Date | 2013-12-06 04:06:00 | ⇒ | 2014-05-06 23:38:18 |
Is there an issue in joomlacode for this?