[#18176] - Fix cases that a submitted form has a multiple-value category id field (e.g. a filtering form), causing notices in article / record forms
- Fixed in Code Base
- 1 Oct 2017
- Medium
- Build: staging
- # 18176
- Diff
- ggppdk:patch-47
User tests: Successful: Unsuccessful:
Pull Request for Issue #17974
This is a rather minor issue, but it looks like easy to fix
Summary of Changes
The category filter (like other filters) in backend articles manager was made multi-value
but there is code in 2 (maybe more) places that assumes that filter is single value
In new article (new record) forms we have
- fields helper trying to load fields of the filtered category
- the category selector of the form trying to auto-select the filtered category
Solution just if posted category id is an array , then use the first category out of the categories
Testing Instructions
- In global configuration set error reporting to maximum
- In article manager select 1 or more categories for the filter,
- Listing reloads
- Now select new article to open new article form
Expected result
- No notices printed
- Custom fields of first category (of categories fillter) are loaded
- Category selector auto selects the first category (of categories fillter)
Actual result
Notices printed, form loads as without any category selected, and 'all categories' fields are shown
Documentation Changes Required
None
joomla-cms-bot
- | Category | ⇒ | Administration com_categories com_fields |
| Status | New | ⇒ | Pending |
| Labels |
Added:
?
|
||
I have tested this item
That was really bothering me.
Hope we can get this in last minute 3.8.1
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18176.
| Milestone |
Added: |
||
| Status | Pending | ⇒ | Ready to Commit |
RTC
@mbabker
I know RC1 is out, but this one is real easy and was badly needed. Please get in 3.8.1 release.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18176.
| Labels |
Added:
?
|
||
I added typecast to integer, it did not exist in previous code,
instead the typecast was done later when using in SQL query,
i think it is good to add it,
since code never check for other values like empty string ''
nothing should be changed in behaviour
@ggppdk Is there other changes that you will make? So I will wait befor re testing.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18176.
I have tested this item
thanks
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18176.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18176.
RTC after two successful tests.
mbabker
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-10-01 14:51:11 |
| Closed_By | ⇒ | mbabker |
I have tested this item✅ successfully on bb13da5
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18176.