[#18171] - [4.0]Replace removed constant RELEASE with correct code, fix #18154
- Fixed in Code Base
- 29 Sep 2017
- Medium
- Build: 4.0-dev
- # 18171
- Diff
- joomdonation:patch-4
- Pending hound Hound is busy reviewing changes... Details
- Pending continuous-integration/drone/pr this build is pending Details
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
This small PR replace the removed RELEASE constant with correct code, fix issue #18154 while installing Joomla 4.0
Testing Instructions
Try to install latest Joomla 4.0-dev. Before patch, there is error and install fails. After patch, install success
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Status | New | ⇒ | Pending |
| Labels |
Added:
?
|
||
Method getUserAgent uses another removed constant DEV_LEVEL which I don't what should be used to replace (or if it is needed), so I remove it for now
The old RELEASE constant is a combination of the newMAJOR_VERSION and MINOR_VERSION constants.
The old DEV_LEVEL constant is a combination of the new PATCH_VERSION and EXTRA_VERSION constants.
For both 3.x and 4.0 https://github.com/joomla/joomla-cms/blob/3.8.0/libraries/src/Version.php#L279 and https://github.com/joomla/joomla-cms/blob/3.8.0/libraries/src/Version.php#L283 should replace the calls for the version number constants to a call to $this->getShortVersion() which is essentially the same result.
| Title |
|
||||||
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-09-29 21:24:52 |
| Closed_By | ⇒ | wilsonge |
I mean the stuff in version.php can be updated. But the updater code i'd be nervous about updating. I think it's ok. But not sure what the deal would be about direct updates
should't this better be patched in 3.x and than merged into 4.0?