[#18169] - php 7.2 compatibility mcrypt checks
- Fixed in Code Base
- 13 Oct 2017
- Medium
- Build: staging
- # 18169
- Diff
- brianteeman:mcrypt
User tests: Successful: Unsuccessful:
PR for 18007
We were checking and reporting on the presence of mcrypt. We no longer need to do that as it is no longer a requirement and mcrypt itself is not present in php 7.2 so the checks would fail anyway then.
Didnt see the point in wrapping it in a conditional php version check as we dont need the info any more
joomla-cms-bot
- | Category | ⇒ | Administration com_admin Installation |
| Status | New | ⇒ | Pending |
| Labels |
Added:
?
|
||
oops I forgot to commit a change - should be ok now
Remove language strings.
Sorry, I keep forgetting that. Then add a deprecate comment?
I see this in the language files:
; This string is deprecated and will be removed with 4.0.
and there are thousands of lines of strings which dont have it and they have been removed
Although COM_ADMIN_MCRYPT_ENABLED should be kept, the specific installation lang strings do not need to remain as the installation folder is totally linked to a new joomla version and not part of Tts lang packs.
as for the 'thousands' of strings which have been deleted in 4.0, it is mostly because a lot of tips have been taken of there (including some that will need to come back in. will make a pr for these).
| Category | Administration com_admin Installation | ⇒ | Administration com_admin Installation Language & Strings |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18169.
With php 7.2 being released next month this should be merged asap
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-10-13 14:09:33 |
| Closed_By | ⇒ | mbabker | |
| Labels |
Added:
?
|
||
Thanks
Should'nt this be dropped too than: https://github.com/joomla/joomla-cms/blob/3.9-dev/administrator/components/com_joomlaupdate/models/default.php#L1113-L1118
?
Or I'm missing something?
Code doesn't exist in staging, only 3.9.
If no one beats me to it I will do a pr for that in 3.9 branch on Sunday
including some that will need to come back in. will make a pr for these
@infograf768 please don't bring back tooltips, fix the labels instead
@infograf768 please don't bring back tooltips, fix the labels instead
Alas, some tips are much too long (and need to be) to be used as labels (the alias tip is only one example).
One idea I have is to change the way these tips are displayed via a ? to click on which would open a modal. Would that be possible and would it be a11y ?
The best a11y is to not use tool tips at all!
OK, then think as a newbie: how do you do for these? Just examples...
@infograf768 for newbies we will have the tour guide. You need to understand we're not in 2006, we're effectively at the end of mobile era and slowly moving into PWA era. Tooltips are not a recommended thing either for mobile or PWA:
and what about the « tour guide » ? will it be available in all languages? I honestly doubt about this: see the state of the help to understand my concern, which also should be yours.
This is completely off topic
I have tested this item? unsuccessfully on 00bae88
PHP Notice: Undefined index: mcrypt in C:\xampp\htdocs\joomla-cms\administrator\components\com_admin\views\sysinfo\tmpl\default_phpsettings.php on line 165This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18169.