[#18166] - [microdata] - worstRating should be 1
- Fixed in Code Base
- 2 Oct 2018
- Medium
- Build: staging
- # 18166
- Diff
- alikon:patch-94
- Pending continuous-integration/drone/pr this build is pending Details
- Success hound No violations found. Woof! Details
- Pending continuous-integration/appveyor/pr Waiting for AppVeyor build to complete Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #18163 .
Summary of Changes
if i'm understanding it right from https://schema.org/AggregateRating the lowest should be '1' and not '0'
joomla-cms-bot
- | Category | ⇒ | Front End Plugins |
| Status | New | ⇒ | Pending |
no you should
Use the Google Structured Data Testing Tool to test the page.
I have tested this item
Changed on a Live-Site to <meta itemprop="worstRating" content="1" / in plugins/content/vote/tmpl/rating.php got:
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18166.
I have tested this item
Changed on a Live-Site to <meta itemprop="worstRating" content="1" / in plugins/content/vote/tmpl/rating.php got:
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18166.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-09-29 12:31:59 |
| Closed_By | ⇒ | alikon | |
| Labels |
Added:
?
|
||
@alikon This PR is fine, it just needs one more fix (unrelated to the original issue) to give valid microdata. Basically the rating info should only be shown if there is at least one rating, if there are zero then the data shouldn't be rendered. This is our layout override on the company site.
reopen with changes
| Status | Pending | ⇒ | Closed |
| Status | Closed | ⇒ | New |
| Closed_Date | 2017-09-29 12:31:59 | ⇒ | |
| Closed_By | alikon | ⇒ |
| Status | New | ⇒ | Pending |
@franz-wohlkoenig can you retest
well i think so if
Google Structured Data Testing Tool
returns you good response
In this Case i can only test on a live site where i change Files. As there is no Patchtester i cannot test (usually i test on Mamp which i can not use for this PR).
| Status | New | ⇒ | Pending |
If somebody touches voting plugin, can we also drop the integer casting in https://github.com/joomla/joomla-cms/pull/18166/files#diff-efed18aee5802b1e8e8639600e9da56eR28 and https://github.com/alikon/joomla-cms/blob/staging/plugins/content/vote/vote.php#L52 as this makes the voting system unusable for many users. Lets add a plugin option where user can select the number of number of decimal places.
Before patch
After patch
If there is no rating in the article page the microdata does not show in Google test tool.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18166.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18166.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18166.
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18166.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-10-02 16:16:13 |
| Closed_By | ⇒ | mbabker | |
| Labels |
Added:
?
|
||
test by Code Review, @alikon?