? ? Pending

User tests: Successful: Unsuccessful:

avatar Bakual
Bakual
29 Sep 2017

Pull Request for Issue #15547.

Summary of Changes

Removing the code which unsets alternative layouts if there is an accompagning XML file (making it an alternative menuitem)

Testing Instructions

  • Create an alternative layout (just the php file) and an alternative menuitem (php file plus xml file).
  • Test that they both can be selected as alternative layout in the global com_content config and in the article.
  • Test that the selected layout is shown in frontend.

Expected result

Alternative menuitems are available also as alternative layouts

Actual result

They're not shown

Documentation Changes Required

Not sure if that is documented anywhere

Caveat

As you can see in the comments, the current behavior seems to be intended. I just don't know why as I can't imagine as side effect.
The code was introduced years ago with https://developer.joomla.org/joomlacode-archive/issue-23054.html

avatar joomla-cms-bot joomla-cms-bot - change - 29 Sep 2017
Category Libraries
avatar Bakual Bakual - open - 29 Sep 2017
avatar Bakual Bakual - change - 29 Sep 2017
Status New Pending
avatar AndySDH
AndySDH - comment - 29 Sep 2017

From the comment in line 184, the part where it says " or that have XML files" should also be removed.

avatar Bakual Bakual - change - 29 Sep 2017
Labels Added: ?
avatar Bakual
Bakual - comment - 29 Sep 2017

@AndySDH You're right!

avatar allrude allrude - test_item - 30 Sep 2017 - Tested successfully
avatar allrude
allrude - comment - 30 Sep 2017

I have tested this item successfully on b21ca67

Works like a charme, like this behaviour better, Thanks Thomas


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18159.

avatar slibbe slibbe - test_item - 6 Oct 2017 - Tested successfully
avatar slibbe
slibbe - comment - 6 Oct 2017

I have tested this item successfully on b21ca67

Thanks for the patch.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18159.

avatar franz-wohlkoenig franz-wohlkoenig - change - 7 Oct 2017
Status Pending Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 7 Oct 2017

RTC after two successful tests.

avatar mbabker mbabker - change - 9 Oct 2017
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-10-09 23:27:59
Closed_By mbabker
Labels Added: ?
avatar mbabker mbabker - close - 9 Oct 2017
avatar mbabker mbabker - merge - 9 Oct 2017

Add a Comment

Login with GitHub to post a comment