? Pending

User tests: Successful: Unsuccessful:

avatar Webdongle
Webdongle
29 Sep 2017

Checking view level of menu item in the admin components menu is not needed. Display of those menu items is controlled by the Permissions in component options not by User Group view level. Corrects error causing #18000 (comment)

Pull Request for Issue # .
#18000

Summary of Changes

Deleted lines that checked view levels in admin menu items

Testing Instructions

  • Set Global Config > Default Access Level --> Guest
  • Install a 3rd party component

Expected result

Menu item for the 3rd party component should be seen

Actual result

Menu item for the 3rd party component is not seen because it is 'Guest' level and SU is not in 'Guest' user group.

Extra tests

Create a test user and set as Administrator
In the Menu item for the 3rd party component's Options set the Administrator Permissions for 'Access Administration Interface ' as 'Denied'
Login with the Test user and make sure the Permission settings are being honoured.

Documentation Changes Required

avatar joomla-cms-bot joomla-cms-bot - change - 29 Sep 2017
Category Modules Administration
avatar Webdongle Webdongle - open - 29 Sep 2017
avatar Webdongle Webdongle - change - 29 Sep 2017
Status New Pending
avatar izharaazmi
izharaazmi - comment - 29 Sep 2017

If first point in my #18000 (comment) is right then this fix is correct. Not because this fixes the issue we are talking of, rather because of the nature of viewing access levels.

avatar AlexRed AlexRed - test_item - 29 Sep 2017 - Tested successfully
avatar AlexRed
AlexRed - comment - 29 Sep 2017

I have tested this item successfully on bd1d805

Patch ok for me.
Thanks


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18156.

avatar infograf768 infograf768 - test_item - 29 Sep 2017 - Tested successfully
avatar infograf768
infograf768 - comment - 29 Sep 2017

I have tested this item successfully on bd1d805

Looks OK to me here.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18156.
avatar franz-wohlkoenig franz-wohlkoenig - change - 29 Sep 2017
Status Pending Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 29 Sep 2017

RTC after two successful tests.

avatar mbabker mbabker - change - 30 Sep 2017
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-09-30 14:40:12
Closed_By mbabker
Labels Added: ?
avatar mbabker mbabker - close - 30 Sep 2017
avatar mbabker mbabker - merge - 30 Sep 2017

Add a Comment

Login with GitHub to post a comment