Composer Dependency Changed Language Change PR-3.9-dev PR-staging RTC

Pending

User tests: Successful: Unsuccessful:

avatar continga
continga
28 Sep 2017

Pull Request for Issue #14565 and following up #14583 and #16599 et al.

Summary of Changes

This PR implements the possiblity to use the Invisible reCAPTCHA using a separate plugin. Besides implementing the basic functionality to make invisible reCAPTCHA working, there has been made some smaller architectural changes to the whole captcha process (e.g. using Exception instead of JError for errors) and the reCAPTCHA PHP library from Google has been updated, alongside with some smaller changes in the old reCAPTCHA (V1 und V2) plugin.

As this is one of my first PRs for Joomla!, please dont hesitate to make suggestions of how to improve it.

Testing Instructions

  1. Create a site- and secret-key at https://www.google.com/recaptcha/admin for an invisible reCAPTCHA (reCAPTCHA V2 keys will not work with Invisible reCAPTCHA)
  2. Configure the Invisible reCAPTCHA plugin in the Joomla! backend, entering at least the site- and secret-key
  3. Configure the Invisible reCAPTCHA plugin to be used as captcha plugin (System -> Global Configuration -> Default Captcha)
  4. Open up a form in the frontend where a captcha is enabled (e.g. by creating a menulink to a contactform)
  5. Notice the reCAPTCHA logo on the right side (see screenshot further down) which indicates that the invisible reCAPTCHA has been executed.

We also need to make sure that the reCAPTCHA plugin (V1 and V2) still is working correctly (as there has been made some bigger changes to the code by me), although I have tested this toroughly already, but I would be very glad if other people could take a look at this too, I don't want to take chances that this PR breaks something.

Additionally, as this PR changes the rendering of form fields for the registration form (this was needed as the registration form was using its own rendering of form fields, which caused issues with the invisible reCAPTCHA), we need to make sure the registration form for users is working as expected. So we need to test the registration form in resprect to custom fields of users etc, and whether they get displayed correctly now.

Expected result

image

avatar joomla-cms-bot joomla-cms-bot - change - 28 Sep 2017
Category Administration Language & Strings External Library Composer Change Libraries Repository Unit Tests
avatar continga continga - open - 28 Sep 2017
avatar continga continga - change - 28 Sep 2017
Status New Pending
avatar brianteeman
brianteeman - comment - 28 Sep 2017

Because of the keys issue would it not make sense to create this as a new plugin?

avatar continga
continga - comment - 28 Sep 2017

V1 and V2 keys also were incompatible, and we had them in the same plugin. Additionally, V2 and invisible share very much of the code (e.g. the whole server-side validation), so I don't see any advantage when using a separate plugin. Additionally, the "key issue" is pretty clear on the Google reCAPTCHA admin page, so I think it shouldn't confuse users. I just wrote it down in the testing information to make clear that new keys has to be created to test this.

avatar brianteeman
brianteeman - comment - 28 Sep 2017

I thought it was a mistake last time as well

avatar continga
continga - comment - 28 Sep 2017

Well, we could do it as a separate plugin now (it is not very much work to disassemble it), but where do you see the advantage exactly?

avatar brianteeman
brianteeman - comment - 28 Sep 2017

You would be able to use invisible!e on some forms and V2 on others.
It will also make future updates easier without having to have switches in the code for the old keys

avatar continga
continga - comment - 28 Sep 2017

Okay, true. Especially the first point is very interesting. I think we should wait for some more feedback, but if the broad agreement is to put it into a separate plugin, I will be very glad to do so.

avatar 810
810 - comment - 28 Sep 2017

i vote for same plugin

avatar Fedik
Fedik - comment - 29 Sep 2017

it should be a plugin, there even a pull request for it, already, somewhere here

avatar paulus103
paulus103 - comment - 20 Oct 2017

Hi This looks a nice feature to add :)

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 28 Oct 2017

@paulus103 can you please test?


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18146.

avatar paulus103
paulus103 - comment - 28 Oct 2017

@franz-wohlkoenig

I have tested this on a live server and it works :)


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18146.

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 29 Oct 2017

@paulus103 thanks for Info. Please mark your Test as successfully:

  • open Issue Tracker
  • Login with your github-Account
  • Click on blue "Test this"-Button above Authors-Picture
  • mark your Test as successfully
  • hit "submit test result"
avatar paulus103 paulus103 - test_item - 31 Oct 2017 - Tested successfully
avatar paulus103
paulus103 - comment - 31 Oct 2017

I have tested this item βœ… successfully on 259a657

tested successfully on an 3.8.1 old development site :)


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18146.

avatar pmleconte
pmleconte - comment - 12 Nov 2017

What can be done, so this pr will be included in 3.8.3. I was disappointed not seeing it in 3.8.2.

If I can help, let me know,

Pascal

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 12 Nov 2017

@pmleconte Pull Requests needs 2 successfully Tests. If you can test this PR, next Step is done.

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 12 Nov 2017

@continga can you please resolve conflicting Files so PR can be tested?

avatar Fedik
Fedik - comment - 12 Nov 2017

I would really suggest to make/test a plugin (there even already one #16599)
and invest your time in to a plugin

avatar franz-wohlkoenig franz-wohlkoenig - change - 12 Nov 2017
Status Pending Needs Review
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 12 Nov 2017

Status is set on "Needs Review".

avatar pmleconte pmleconte - test_item - 12 Nov 2017 - Tested successfully
avatar pmleconte
pmleconte - comment - 12 Nov 2017

I have tested this item βœ… successfully on 259a657

Test ok on 3.8.1 site. Both V2 and invisible captcha are OK.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18146.

avatar joomla-cms-bot joomla-cms-bot - change - 13 Nov 2017
Category Administration Language & Strings External Library Composer Change Libraries Repository Unit Tests Administration Language & Strings External Library Composer Change SQL Installation Postgresql MS SQL Libraries Repository Unit Tests
avatar continga continga - change - 13 Nov 2017
The description was changed
avatar continga continga - edited - 13 Nov 2017
avatar continga
continga - comment - 13 Nov 2017

After the feedback here, I decided tocompletely rework my implementation and to swap out the Invisible reCAPTCHA implementation into its own plugin.

I additionally removed the support for reCAPTCHA V1, as this has been dropped by Google[1]. Users should switch to V2 or Invisible.

I would be very glad to receive additional feedback, especially if you see anything that can (and should) be done better. I would be very glad to enhance this to a point where we can get this merged.

[1] = https://developers.google.com/recaptcha/docs/versions#v1

avatar franz-wohlkoenig franz-wohlkoenig - change - 13 Nov 2017
Status Needs Review Pending
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 13 Nov 2017

Status is set back on "Pending".

avatar brianteeman
brianteeman - comment - 13 Nov 2017

The recaptcha v1 will continue to work until march 2018. It has already been removed from j4

avatar continga
continga - comment - 13 Nov 2017

Nvm, I reverted removing V1 functionality.

avatar continga continga - change - 13 Nov 2017
The description was changed
avatar continga continga - edited - 13 Nov 2017
avatar continga continga - change - 13 Nov 2017
Labels Added: Composer Dependency Changed Language Change PR-staging ?
avatar joomla-cms-bot joomla-cms-bot - change - 16 Nov 2017
Category Administration Language & Strings External Library Composer Change Libraries Repository Unit Tests SQL Installation Postgresql MS SQL SQL Administration com_admin Postgresql MS SQL Language & Strings External Library Composer Change Installation Libraries Repository Unit Tests
avatar continga
continga - comment - 16 Nov 2017

@paulus103 @pmleconte Can you maybe re-test this PR, after I switched the functionality to a separate plugin? Thanks in advance!

avatar pmleconte
pmleconte - comment - 17 Nov 2017

Hi,

I'm trying to install your new plugin as an update on an 3.8.2 website.
I tried different update channels (Testing, Next Joomla, Default) without success. Am I missing something ? is your zip file supposed to work in update mode ?
On a new install, V2 and Invisible captcha are OK.
So, should I set test as OK ?
Pascal

avatar pmleconte pmleconte - test_item - 20 Nov 2017 - Tested successfully
avatar pmleconte
pmleconte - comment - 20 Nov 2017

I have tested this item βœ… successfully on 145b123

V2 and invisible captcha Ok on a new Joomla installation.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18146.

avatar cymode
cymode - comment - 30 Nov 2017

Is there tutorial on how to add this to Joomla for testing purposes? I've got a multitude of joomla environments and wouldn't mind testing this in dev and small live sites.

avatar Quy
Quy - comment - 1 Dec 2017

Go here for testing instructions/tutorial: https://docs.joomla.org/Testing_Joomla!_patches

avatar continga
continga - comment - 2 Dec 2017

@pmleconte There are database update scripts inside of administrator/components/com_admin/sql/updates which are not executed when you manually appy the changes made by this PR to your Joomla! installation. One possibility would be to execute the SQL scripts manually, after having applied the patch.

These SQL update scripts should be executed automatically once this PR gets merged and released within the 3.8.2 release - can someone else confirm this, or do I need to add some additional stuff for it to work?

avatar 810
810 - comment - 27 Dec 2017

Could you update the pr.

Then we can do the final tests.

avatar coolcat-creations
coolcat-creations - comment - 22 Mar 2018

When I go on google invisible recaptcha the registration site is down. Is that method "taken down" ?

avatar brianteeman
brianteeman - comment - 22 Mar 2018

I just signed up to it

avatar pmleconte
pmleconte - comment - 23 Mar 2018

Whenever this PR will be updated, I'll be ready to test it again.

Pascal

avatar coolcat-creations
coolcat-creations - comment - 26 Mar 2018

https://www.google.com/recaptcha/intro/comingsoon/invisible.html
That's the only address I can find for signing up. When I click the link the form is not available?

avatar pmleconte
pmleconte - comment - 28 Mar 2018

Just click on "continue" instead of "sign up" and you should be able to register for "invisible captcha".

Pascal

avatar roland-d
roland-d - comment - 14 May 2018

@continga Can you fix the conflicts?

avatar continga
continga - comment - 17 May 2018

I will do this at some time next week, sorry for the delay, didn't have time for this yet

avatar roland-d
roland-d - comment - 17 Jul 2018

@continga Do you have time to work on this or shall I get someone to work on it?

avatar continga
continga - comment - 17 Jul 2018

@roland-d sorry, you are absolutely right, I should have worked on this much sooner. Thank you for the reminder, and sorry again for the huge delay!

I resolved all conflicts now. I needed to squash-rebase this whole thing, as the conflicts were CRAAAZYΒ³ when doing a normal rebase due to having reworked this thing several times, and a lot of stuff happened in Joomla since - we lost a bit of history due to this (the main thing is now inside of 1 commit), but I think this should be OK.

I hope we are good now. Please do some tests and let's try to bring this into one of the next minor releases. I promise to react on fast feedback very fast this time ;-) I hope we can finally get this off the pipe!

avatar coolcat-creations
coolcat-creations - comment - 18 Jul 2018

I don't know if something like google recaptcha should be in core since it's something that is also discussed due to gdpr and it's an external service... Wouldn't it be better to have something "own" ?

Sorry for disturbing the party...

avatar roland-d
roland-d - comment - 18 Jul 2018

Wouldn't it be better to have something "own" ?
I disagree with this because first of all I don't think we should invent everything ourselves just because of GDPR. GDPR doesn't forbid using external services. We will not build such an intelligent recaptcha ourselves.

We don't force users to use this, it is optional when they want to use this.

avatar coolcat-creations
coolcat-creations - comment - 18 Jul 2018

It does not forbid it, but the user should be aware he has to sign a contract with google to be legal to use it - well at least in germany with the DSGVO...

avatar brianteeman
brianteeman - comment - 18 Jul 2018

It is not joomla's job to ensure that a web site is compliant to every law in every country of the world nor is it joomla's job to educate users in those countries of their own laws. We don't force or even tell people about impressum do we? We dont force or tell people about a11y laws

avatar coolcat-creations
coolcat-creations - comment - 18 Jul 2018

If someone is adding a 3rd party to Joomla, the argument is always that we don't do that.
I was trying to consider that fact that we usually try to avoid that.
Personally I would find it good to have something in core that is independant of Google. But if you don't agree, it's ok.

avatar cymode
cymode - comment - 18 Jul 2018

briantreeman - that's a stupid response. When 1/5 of the world has to be GDPR compliant why should Joomla not be...
That being said, this tool is GDRP compliant. You just need to mention it in your privacy policy so I don't know what people are moaning about.

avatar coolcat-creations
coolcat-creations - comment - 18 Jul 2018

@brianteeman @cymode
It's OK -> we can take into account that we report that to the new com_privacy then and all is fine.
I was asking about that also because of above stated reasons (Independence of 3rd party) - but if you all decide that its ok, I am fine...

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 18 Jul 2018

that's a stupid response.

i don't like that kind of "Argument".

avatar WilkoRietveld
WilkoRietveld - comment - 18 Jul 2018

Can someone explain me what the test instruction are, to move this forward?

avatar mbabker
mbabker - comment - 18 Jul 2018

Wouldn't it be better to have something "own" ?

If someone in the Joomla community really thinks they can create and maintain a captcha system that is arguably as smart and secure as existing third party solutions, feel free to do so. Fact is there are a lot of bits and pieces of Joomla that we really need to offload onto the shoulders of third party solutions (be it PHP or UI related libraries or services like captcha) because we don't have the resources to build and maintain every single thing ourselves.

avatar brianteeman
brianteeman - comment - 18 Jul 2018

The sql import etc suggests that this is a NEW plugin but the xml file is the xml for the original recaptcha plugin

avatar brianteeman
brianteeman - comment - 18 Jul 2018

it looks like you got a bit confused when updating the pr and you have changed files from the existing recaptcha plugin which should have been new files for this invisible-recaptcha plugin

avatar continga
continga - comment - 18 Jul 2018

What do you mean exactly? As far as I see, this is not the case, i.e. the XML file is completely new ( https://github.com/joomla/joomla-cms/pull/18146/files#diff-1e6b80a6f1929ba0e37a095f7c2fb985 ). Can you show me what you are referring to?

avatar continga
continga - comment - 18 Jul 2018

Yeah, part of this PR was to remove the JReCaptcha class, so there was some stuff that needed to be done in the old plugin - I took that possibility to pass all per documentation possible parameters to the reCAPTCHA v2 javascript instance (see also https://github.com/joomla/joomla-cms/pull/18146/files#diff-b934bb49d0402bc42e4577e744d93a95 ). Additionally I did some general code cleanup in the old plugin.

Are you suggesting this should be removed?

avatar brianteeman
brianteeman - comment - 18 Jul 2018

Its always confusing when there are more than one issue being addressed in a single pr - especially when there is no mention of it in the original post and testing instructions. Obviously as you have changed the existing plugin as well in this pr then that needs to be tested to ensure it still works

avatar brianteeman
brianteeman - comment - 18 Jul 2018

With invisible recaptcha enabled we still have the label for the field displayed in the form. This will confuse users who see a required field but no way for them to complete the field

chrome_2018-07-18_13-29-41

avatar continga
continga - comment - 18 Jul 2018

uuuh, I mentioned that in my OP:

We also need to make sure that the reCAPTCHA plugin (V1 and V2) still is working correctly (as there has been made some bigger changes to the code by me), although I have tested this toroughly already, but I would be very glad if other people could take a look at this too, I don't want to take chances that this PR breaks something.

I will take a look at that bug with the label tonight or tomorrow, that should have been fixed already, but I will why its popping up again. Thanks for testing this!

avatar coolcat-creations
coolcat-creations - comment - 18 Jul 2018

I made a PR for that that is not merged yet...

avatar brianteeman
brianteeman - comment - 18 Jul 2018

sorry I missed that part of the post

avatar coolcat-creations
coolcat-creations - comment - 18 Jul 2018

Sorry it is merged: #18431

avatar brianteeman
brianteeman - comment - 18 Jul 2018

Do we really need to expose the tabindex and the callback options ?

avatar brianteeman
brianteeman - comment - 18 Jul 2018

also i see that you expose the expired callback option in the recaptcha v2 plugin but not in the invisible plugin

avatar continga
continga - comment - 18 Jul 2018

@coolcat-creations I will take a look at that, thank you.

@brianteeman You are right. Not sure how this happened, I am pretty sure I got all options covered when I wrote the plugin. I think Google added this option at a later date. I will double-check this once again and add all missing options (will also check for the old plugin).

And yes, I think it makes sense to expose those to the user. Imho they can be useful in some situations, and we shouldn't force the user to hack the core to could use them

avatar joomla-cms-bot joomla-cms-bot - change - 21 Jul 2018
Category Administration Language & Strings External Library Composer Change Libraries Repository Unit Tests SQL Installation Postgresql MS SQL com_admin Repository SQL Administration com_admin Postgresql MS SQL Language & Strings External Library Composer Change Installation Libraries
avatar continga
continga - comment - 21 Jul 2018

I just updated this PR and should've accounted all feedback so far. Can you guys take a look again? πŸ™‚

@brianteeman I could not reproduce the bug with the label. Can you check whether it still happens, or give me some more information about your environment?

avatar continga continga - change - 21 Jul 2018
Labels Removed: ?
avatar roland-d
roland-d - comment - 21 Jul 2018

@continga I have been testing and running into a few issues.

image

The captcha label should not be shown as now the form looks broken.

After I submit the form I am greeted by this error:
image

So I deleted the autoload_psr4.php file but the error remains.

There is no language entry for these labels

label="PLG_RECAPTCHA_INVISIBLE_ERROR_CALLBACK_LABEL"
description="PLG_RECAPTCHA_INVISIBLE_ERROR_CALLBACK_DESC"

It would be nice to have larger input boxes
image

This way you can see your keys better.

avatar mbabker
mbabker - comment - 21 Jul 2018

So I deleted the autoload_psr4.php file but the error remains.

@roland-d There are no dynamically generated autoloader files in 3.x so if you're deleting autoload files make sure you didn't nuke something from the Composer package.

avatar brianteeman
brianteeman - comment - 21 Jul 2018

As you can see @roland-d has reported the same label issue

avatar continga
continga - comment - 22 Jul 2018

Okay, I found the reason for the "label problem". The problem is, that the com_users registration view, components/com_users/views/registration/tmpl/default.php, between lines 34 and 49 renders the input fields completely by himself, and does not take into account the hiddenLabel attribute of the field XML, see for reference components/com_contact/layouts/joomla/form/renderfield.php#L48 or layouts/joomla/form/renderfield.php#L32

If we would replace those 16 lines, with only this single 1 line:

<?php echo $field->renderField(); ?>

Then the field renderer of Joomla! is being used to render that form, and the problem is solved for the registration form. I did some quick tests, and I did not see any differences in the generated form when using $field->renderField() instead of the current implementation, but I am unsure whether this would be the way to fix this.

So my question to you guys: What do you think about this, should the fix be to use the renderField method of each field there, and to replace the current manual-rendering of those? Or do you see any problems with that?

edit: All other points should be fixed now (so the Call to undefined method, missing translation, larger input boxes things)

avatar coolcat-creations
coolcat-creations - comment - 22 Jul 2018

Do Custom fields still work with your change?

avatar continga
continga - comment - 22 Jul 2018

Custom Fields in the registration form? Yes, I think they will still work. To be honest, I think they will work even better than before, as they will be rendered completely using their own mechanics - and not using the "hardcoded" way in the registration view like before.
But, as I said before, I'd like to get some more input to that point

avatar mbabker
mbabker - comment - 22 Jul 2018

Then the field renderer of Joomla! is being used to render that form, and the problem is solved for the registration form. I did some quick tests, and I did not see any differences in the generated form when using $field->renderField() instead of the current implementation, but I am unsure whether this would be the way to fix this.

In general I would suggest that unless there is some major need for styling that contradicts what the form fields and their layouts render that $field->renderField() should always be used (or, if you have all the fields enclosed into a fieldset, $form->renderFieldset($fieldset->name);). Not doing so actually makes it harder to use plugins to dynamically alter forms and I'd almost suggest adding a static analysis tool raising warnings about manual rendering of field elements (echo $field->label; or echo $field->input;).

avatar continga
continga - comment - 22 Jul 2018

I totally agree with you @mbabker and that is also why I want to change this. Good to know you are the same meaning. Let us wait for some more feedback, but you just verified to me that'd be the way to go πŸ™‚

avatar roland-d
roland-d - comment - 23 Jul 2018

@continga I also agree with your findings and those of @mbabker . Just like com_contacts we would need a layout override file to account for this code:

<?php if (!$field->required && $field->type !== 'Spacer') : ?>
										<span class="optional"><?php echo JText::_('COM_USERS_OPTIONAL'); ?></span>
<?php endif; ?>

This is also done for com_contacts. That would clean up nicely.

avatar joomla-cms-bot joomla-cms-bot - change - 24 Jul 2018
Category Administration Language & Strings External Library Composer Change Libraries Repository SQL Installation Postgresql MS SQL com_admin Repository SQL Administration com_admin Postgresql MS SQL Language & Strings Front End com_users External Library Composer Change Installation Libraries
avatar continga
continga - comment - 24 Jul 2018

I now fixed the label issue, see commit f75d99c6.

Now from my point of view every feedback and review-change-request has been applied. Can you guys maybe take a look again and check whether this is mergable? This PR is pretty old and I am crossing fingers we finally get this thing merged πŸ™‚ Thank you in advance!

avatar continga continga - change - 24 Jul 2018
The description was changed
avatar continga continga - edited - 24 Jul 2018
avatar roland-d
roland-d - comment - 27 Jul 2018

@continga I am sure we will get it merged once all issues are solved :)

When I do a password reset, I see this form:
image

Same when I do forget username I see this form:
image

So I think for these 2 pages you still need to add the layout fix.

Looking good:

  • New user registration
  • Contact form
  • Edit article

Those are the only places I can think of and find where the captcha could be shown.

avatar continga
continga - comment - 28 Jul 2018

Thanks @roland-d I fixed the cases you found.

Additionally I checked the sourcecode for other cases where form fields are being rendered manually and found some additional ones in the com_users login, password reset confirmation and success views. There shouldn't be a captcha there, but just to be sure I replaced the manual rendering with the Form renderer.

As far as I see, the only other places where forms are being rendered manually now are in several com_config views, and in the profile edit view of com_users. Both cases are not easily straight-forward replaceable by the Form renderer, so I left them in their current state, also because they don't display a captcha at all.

Can you check again? ☺️ Thank you very much in advance!

avatar roland-d roland-d - test_item - 29 Jul 2018 - Tested successfully
avatar roland-d
roland-d - comment - 29 Jul 2018

I have tested this item βœ… successfully on 67ac41a

After applying the patch I setup the ReCaptcha invisible settings in the plugin and after that I tested the following view:

  1. User Registration (http://joomla-cms-live.test/index.php?option=com_users&view=registration&Itemid=405)
  2. Forgot Password (http://joomla-cms-live.test/index.php?option=com_users&view=reset&Itemid=409)
  3. Forgot Username (http://joomla-cms-live.test/index.php?option=com_users&view=remind&Itemid=406)
  4. Edit an article (http://joomla-cms-live.test/index.php?option=com_content&view=form&layout=edit&a_id=6&Itemid=257&catid=26)
  5. Contact Form (http://joomla-cms-live.test/index.php?option=com_contact&view=contact&id=1&Itemid=229)

All the views show the Captcha logo and allowed me to process the form successfully.

I had a look at the JS callbacks as well they work fine for me.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18146.

avatar MastersOfMedia
MastersOfMedia - comment - 12 Aug 2018

I have tested this item βœ… successfully on 67ac41a

βœ… I have tested this item succesfully on a fresh install of Joomla! 3.8.11. On all 5 forms the invisible ReCaptcha badge show correctly and I was able to enter and process the form data correctly. By altering the keys in the plugin settings I was able to determine the validation actually works correctly.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18146.

avatar MastersOfMedia MastersOfMedia - test_item - 12 Aug 2018 - Tested successfully
avatar franz-wohlkoenig franz-wohlkoenig - change - 13 Aug 2018
Status Pending Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 13 Aug 2018

Ready to Commit after two successful tests.

avatar mbabker mbabker - change - 28 Aug 2018
Labels Added: RTC
avatar mbabker
mbabker - comment - 28 Aug 2018

Merged to 3.9-dev via 9a12f28

avatar mbabker mbabker - change - 28 Aug 2018
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2018-08-28 23:30:03
Closed_By mbabker
Labels Added: PR-3.9-dev
avatar mbabker mbabker - close - 28 Aug 2018
avatar brianteeman
brianteeman - comment - 30 Aug 2018

@tecpromotion
Good spot

as this has been merged already can you do a PR to fix it - or shall I ?

avatar tecpromotion
tecpromotion - comment - 30 Aug 2018

@brianteeman
It would be an honor for me to write the PR. I found the mistake because I'm doing the german translation :)

Add a Comment

Login with GitHub to post a comment