?
avatar infograf768
infograf768
27 Sep 2017

Steps to reproduce the issue

Display Articles Options (same issue for other components using custom fields).
Set Enable Custom fields to No.

screen shot 2017-09-27 at 08 10 49

Result

The Fields and Field Groups do not display in the sidebar => That's OK.
They still display in the Admin menu => WRONG

screen shot 2017-09-27 at 08 15 26

@izharaazmi

avatar infograf768 infograf768 - open - 27 Sep 2017
avatar joomla-cms-bot joomla-cms-bot - change - 27 Sep 2017
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 27 Sep 2017
avatar infograf768
infograf768 - comment - 27 Sep 2017

OK. I have a patch ready. Will post now.

avatar izharaazmi
izharaazmi - comment - 27 Sep 2017

I have a question here.

Its a good thing that we can detect the settings in extension too detect such things. But if we are doing this only for core and allowing no way to do the same for other developers (3DP) then we are doing it wrong.

Think of a case where a component com_tasks allows users to create two type of items (such as users and groups), each having a menu item link in admin. Now there is a setting in the extension to disable either or both type of items. How do we hide that menu item? Mind it that module manager doesn't know about this com_tasks.

avatar joomla-cms-bot joomla-cms-bot - change - 27 Sep 2017
Closed_By franz-wohlkoenig joomla-cms-bot
avatar joomla-cms-bot joomla-cms-bot - close - 27 Sep 2017
avatar franz-wohlkoenig franz-wohlkoenig - change - 27 Sep 2017
Status New Closed
Closed_Date 0000-00-00 00:00:00 2017-09-27 07:46:07
Closed_By franz-wohlkoenig
avatar joomla-cms-bot
joomla-cms-bot - comment - 27 Sep 2017
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 27 Sep 2017

closed as having Pull Request #18137


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18136.

avatar franz-wohlkoenig franz-wohlkoenig - change - 27 Sep 2017
Status Closed Discussion
Closed_Date 2017-09-27 07:46:07
Closed_By joomla-cms-bot
avatar joomla-cms-bot joomla-cms-bot - change - 27 Sep 2017
Status Discussion New
Closed_Date 0000-00-00 00:00:00
avatar joomla-cms-bot joomla-cms-bot - reopen - 27 Sep 2017
avatar joomla-cms-bot
joomla-cms-bot - comment - 27 Sep 2017
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 27 Sep 2017

sorry @izharaazmi, reopened.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18136.

avatar infograf768
infograf768 - comment - 27 Sep 2017

Think of a case where a component com_tasks allows users to create two type of items (such as users and groups), each having a menu item link in admin. Now there is a setting in the extension to disable either or both type of items. How do we hide that menu item? Mind it that module manager doesn't know about this com_tasks.

Do you have a better solution than #18137 ?

IMHO, 3pd should follow core on this: i.e. use same param and both field groups and fields enabled/disabled at the same time.

avatar izharaazmi
izharaazmi - comment - 27 Sep 2017

@infograf768 If we deal with com_fields only then it would be fine. But what I am trying to solve is to support custom logic that depends on the component itself.

In our case with com_fields same thing can be seen as com_fields would decide whether to show that menu item or not. For this com_fields may require other components which uses its features to follow certain rules viz. already we have – custom_fields_enable attribute.

So what we need here now is that the ability to pass the control to the component which the menu item belongs and let it decide whether to show or not.

avatar infograf768
infograf768 - comment - 27 Sep 2017

So what we need here now is that the ability to pass the control to the component which the menu item belongs and let it decide whether to show or not.

Understand. As the PR only deals with com_fields and we do not have yet that ability, Ietme close this one again.

avatar infograf768 infograf768 - change - 27 Sep 2017
Status New Closed
Closed_Date 0000-00-00 00:00:00 2017-09-27 09:22:47
Closed_By infograf768
avatar infograf768 infograf768 - close - 27 Sep 2017
avatar izharaazmi
izharaazmi - comment - 27 Sep 2017

@infograf768 Closed, fine. Just wanted to know whether you support this approach or have some suggestions to improve?

avatar infograf768
infograf768 - comment - 28 Sep 2017

The approach looks fine (using helpers) but I am afraid we find out it implies important changes and may not be ready for 3.8.1 (or even the 3.x.x series) as 3pds using custom fields would have to modify their code.

avatar izharaazmi
izharaazmi - comment - 28 Sep 2017

If I do it, I't make sure it is compatible to 3.x

Add a Comment

Login with GitHub to post a comment