[#18120] - Editor Buttons in TinyMCE use `` instead of `` for icons
- Closed
- 27 Sep 2017
- Medium
- Build: staging
- # 18120
Steps to reproduce the issue
Check the editor-xtd buttons in TinyMCE. The icons use a <i> tag instead of a (semantically correct) <span> tag.
In other editors where the buttons are shown below the editor, <span> is used.
Expected result
Uses span
Actual result
Uses i (italic)
Additional comments
Now this may be something which comes from TinyMCE itself.
I noticed because it broke the icon for the ARS button (akeeba/release-system#126) and may as well have broken it for other extensions.
joomla-cms-bot
- | Title |
|
||||||
| Labels |
Added:
?
|
||||||
| Category | ⇒ | Code style |
| Status | New | ⇒ | Confirmed |
infograf768
- | Title |
|
||||||
<i> tags are generated inside media/editors/tinymce/tinymce.min.js file
Can we do anything or is that something which has to be fixed upstream in the TinyMCE repo?
We need to open an issue upstream. Although this is a b/c breaking change so keep low expectations
As the version of tinymce we use in j3 is no longer actively supported i would not expect an update. If the newer version of tinymce that is used in J4 has the same issue then it might be fixed there but wont help the issue reported here
I opened an issue on their repo: tinymce/tinymce#3954
Lets see how it goes.
I'm closing this one here.
| Status | Confirmed | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-09-27 12:47:22 |
| Closed_By | ⇒ | Bakual |
we can fix it ourselves by creating our own theme for tinymce instead of using one of the vendor supplied themes (if i read the code correctly)
Status "Confirmed" on Issue Tracker.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18120.