? ? Pending

User tests: Successful: Unsuccessful:

avatar joomlart
joomlart
25 Sep 2017

…ecated

Use Text::getScriptStrings() instead.

Pull Request for Issue # .

Summary of Changes

Testing Instructions

Expected result

Actual result

Documentation Changes Required

avatar joomla-cms-bot joomla-cms-bot - change - 25 Sep 2017
Category Libraries
avatar joomlart joomlart - open - 25 Sep 2017
avatar joomlart joomlart - change - 25 Sep 2017
Status New Pending
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 28 Oct 2017

Can you give Test Instructions so People with less Dev-Knowledge can test?


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18101.

avatar Quy
Quy - comment - 19 Dec 2017

Go to Extensions > Plugins > System - Debug.
Under Logging tab, enable Log Deprecated API.
Go to the frontend.
Open the log file @ \administrator\logs\deprecated.php
Search for As of 3.7.0, passing a null value for the first argument of Joomla\CMS\Language\Text::script() is deprecated and will not be supported in 4.0. Use the Joomla\CMS\Language\Text::getScriptStrings() method to get the strings from the JavaScript language store instead.
After PR, no warning above.

avatar Quy Quy - test_item - 19 Dec 2017 - Tested successfully
avatar Quy
Quy - comment - 19 Dec 2017

I have tested this item successfully on 963fee1


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18101.

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 20 Dec 2017

@Quy without PR got 300+ Warnings but not the one you wrote.

avatar Quy
Quy - comment - 20 Dec 2017

Please try again with the Test English (GB) Sample Data demo.

avatar franz-wohlkoenig franz-wohlkoenig - test_item - 20 Dec 2017 - Tested successfully
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 20 Dec 2017

I have tested this item successfully on 963fee1


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18101.

avatar joomla-cms-bot joomla-cms-bot - edited - 20 Dec 2017
avatar franz-wohlkoenig franz-wohlkoenig - change - 20 Dec 2017
Status Pending Ready to Commit
avatar joomla-cms-bot joomla-cms-bot - edited - 20 Dec 2017
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 20 Dec 2017

Ready to Commit after two successful tests.

avatar mbabker mbabker - change - 21 Dec 2017
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-12-21 00:13:24
Closed_By mbabker
Labels Added: ? ?
avatar mbabker mbabker - close - 21 Dec 2017
avatar mbabker mbabker - merge - 21 Dec 2017

Add a Comment

Login with GitHub to post a comment