Pending

User tests: Successful: Unsuccessful:

avatar okonomiyaki3000
okonomiyaki3000
5 Apr 2012

Add support for multi-file upload via the file input tag's 'multiple' attribute
Bug fix for long-standing folder creation bug where 'continue' was used outside of loop context
Various code cleanup

avatar okonomiyaki3000 okonomiyaki3000 - open - 5 Apr 2012
avatar okonomiyaki3000
okonomiyaki3000 - comment - 5 Apr 2012

I noticed that the 'delete' function in the file controller and the folder controller seem to be basically the same. Why not make both of these classes inherit from MediaController and put the delete function there instead?

avatar infograf768
infograf768 - comment - 5 Apr 2012

Please opem a tracker on joomlacode and reference here.

avatar okonomiyaki3000
okonomiyaki3000 - comment - 5 Apr 2012

I would be happy to do that if only I could stay logged in to joomlacode long enough. I have posted here multiple times about this problem. Am I the only one? I log in, click a link or two and suddenly I'm logged out again. It happens no matter what browser I use, whether I access from home or work, mac or windoze. Does that site actually function for some people? What's the secret?

avatar elinw
elinw - comment - 10 Apr 2012

You usually have to log in twice. No idea why but it seems to work.

avatar okonomiyaki3000
okonomiyaki3000 - comment - 11 Apr 2012

Well, look, I managed to fight my way to the tracker submission page (twice) and submit the issue. But, of course, I was logged out as soon as I clicked the submit button and the issue did not appear in the list.

Is there any person actually responsible for joomlacode who I could get some support from? Or was that site just set up years ago and left to rot? I see that issues have been posted to the tracker as recently as yesterday (or maybe it's today, I'm probably a day ahead) so it seems to work for somebody. What is the secret? No, logging in twice doesn't change a thing.

Actually, I can go into more detail about the login problem. If I log in at http://joomlacode.org/gf/account/?action=Login I will get in and be redirected to 'My Page'. But almost any action gets me logged out and sent back to the login page with a 'redirect' parameter. If I submit the login form while that parameter is in the url, I will always just end up back at the same login form. The only way I can successfully log in is to remove that parameter, but then I end up back at 'My Page' and unable to get to other pages without being logged out again. I'm trying to be patient with this thing but it's quite frustrating.

avatar elinw
elinw - comment - 12 Apr 2012

Yes it works really well for dozens of people everyday. I've asked Sam to take a look at if there is a problem with your account.

avatar okonomiyaki3000
okonomiyaki3000 - comment - 13 Apr 2012

elinw, thanks, I hope it can be fixed soon.

realityking, thanks for the feedback. I think I should first modify the upload function so that it works whether Filedata is an array or not (well, it's always an array but you know what I mean). After that, it will up to the template to either use this feature or stick with single file uploads. As to the doctype, do you know if there is any plan to switch to HTML5 or any reason not to do so?

avatar realityking
realityking - comment - 13 Apr 2012

I'm pretty sure we're gonna switch to the HTML5 Doctype for 3.0, not sure we wanna touch that for 2.5.

Personally I don't mind the invalid attribute too much, also I'd be willing to trade the small change required to layout overrides for simpler code but at the end that's a call to be made by leadership.

avatar okonomiyaki3000
okonomiyaki3000 - comment - 13 Apr 2012

Oh, and I've added a couple of functions but I didn't add a '@since'. What will be the next version?

avatar okonomiyaki3000
okonomiyaki3000 - comment - 13 Apr 2012

As you can see, getting it to work properly whether or not multiple is set in the template doesn't really complicate the code in any significant way. Probably better to be a little more robust and backward compatible here. That being said, the built in templates don't seem to override this page. Maybe some 3rd party ones do? Are there 3rd party admin templates?

avatar realityking
realityking - comment - 16 Apr 2012

There are a few other admin templates, for example AdminPraise.

avatar okonomiyaki3000
okonomiyaki3000 - comment - 17 Apr 2012

I see. Well, in any case, this change should not break the functionality of any template.

avatar okonomiyaki3000
okonomiyaki3000 - comment - 20 Apr 2012

Slight change of subject so maybe I should start a new thread but this looks pretty good. I might try to write a module for it if I have some spare time. Any thoughts?

avatar okonomiyaki3000
okonomiyaki3000 - comment - 24 Apr 2012

@elinw Any word from sam about this joomlacode problem?

avatar okonomiyaki3000
okonomiyaki3000 - comment - 6 Jun 2012

@elinw

I seem to have worked this out. It looks like it was something to do with my company's network after all. I don't understand it but at least I have a solution.

Now, to post a report (and I have several) I need to associate it with a 'project'? There are heaps of projects on joomlacode, most of them look like 3rd party plugins. Is there a project just for com_media or would this be considered as part of some core Joomla project? I also have things to post about CodeMirror, what project would that be listed as?

avatar mbabker
mbabker - comment - 6 Jun 2012
avatar elinw
elinw - comment - 7 Jun 2012

No don't do a project, you want this to be part of the core Joomla cms
project.

Elin

On Wed, Jun 6, 2012 at 3:18 AM, Elijah Madden <
reply@reply.github.com

wrote:

@elinw

I seem to have worked this out. It looks like it was something to do with
my company's network after all. I don't understand it but at least I have a
solution.

Now, to post a report (and I have several) I need to associate it with a
'project'? There are heaps of projects on joomlacode, most of them look
like 3rd party plugins. Is there a project just for com_media or would this
be considered as part of some core Joomla project? I also have things to
post about CodeMirror, what project would that be listed as?


Reply to this email directly or view it on GitHub:
#181 (comment)

avatar okonomiyaki3000 okonomiyaki3000 - close - 7 Aug 2012
avatar coolbung coolbung - reference | 56c4ea9 - 8 Sep 13

Add a Comment

Login with GitHub to post a comment