User tests: Successful: Unsuccessful:
Refactored ExceptionHandler class (previously JErrorPage): separated logging and rendering, added helper methods, replaced old class names (JXxx) with namespaced ones.
ExceptionHandler::render() is called manually from anywhere, no logging is performed. If
ExceptionHandler::handleException() is called, both logging and rendering is performed.
Enter non-existing url in browser to trigger 404 page.
Default template error page should be displayed, as usual.
I get there's an element of single responsibility here - but is there a practical reason for breaking this up?
Yes. The separation allows to render default error page from plugins without logging. My clients were using custom loggers on almost all projects.
Added: Joomla 3.9.0
Removed: Joomla 3.9.0
Added: Joomla 3.10.0
Drone is happy now so whatever was there in the past that is now fixed and that extra code is not needed. Tests would be great :)
Applying patch has no effect on the 404.
Note: Check you have a Joomla .htaccess file in correctly first otherwise you'll be looking at a server level error message instead!
|Status||Pending||⇒||Ready to Commit|
|Status||Ready to Commit||⇒||Fixed in Code Base|
|Closed_Date||0000-00-00 00:00:00||⇒||2020-09-26 07:54:09|
Sorry, I missed a word in the comment. It should have said "This should not have been merged". Neither the original code, nor the merged code is fine.
Yes that check has been removed and the test issues mention does not seem to happen anymore with drone. We have to take into account that this was an 2017er PR with a totally different testing setup :)
In that case the code you removed should be restored but without
preg_match('~\Atest[A-Z]~', $callerFunction) check.