did you mean to change the code in the simplepie file or is that a search/replace error? That is a vendor supplied file and we wouldnt usually touch those files

@brianteeman I added it as an to be safe as wasn't 100% sure it was a simpleXML element. I didn't check the full path so didn't notice it was vendor specific. I've reverted that one now, thanks!

Part of this is already in https://issues.joomla.org/tracker/joomla-cms/18054 (which I tested OK).

Maybe better close #18054 ?

Whoops! I closed the issue not the pull too, thanks. I’ve now closed that
pull.

--
Tony Partridge

On 22 September 2017 at 10:32:32, infograf768 (notifications@github.com)
wrote:

Part of this is already in
https://issues.joomla.org/tracker/joomla-cms/18054 (which I tested OK).

Maybe better close #18054 #18054
?

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#18061 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABVglppOcyqm6yH3cQgNcEI0Jq41Uhx8ks5sk36wgaJpZM4PgaPH
.

No Comment… updated.

--
Tony Partridge

On 22 September 2017 at 11:16:29, George Wilson (notifications@github.com)
wrote:

@wilsonge commented on this pull request.

In libraries/src/Form/Field/TagField.php
#18061 (comment):

@@ -243,7 +243,7 @@ public function isNested()
if ($this->isNested === null)
{
// If mode="nested" || ( mode not set & config
= nested )

•                   if (isset($this->element['mode']) && (string)
  

$this->element['mode'] === 'nested'

•                   if (isset($this->element['mode']) && (string)
  

(string) $this->element['mode'] === 'nested'

You have two string typehints here ;)

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#18061 (review),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABVglkp5cOCo92orH-Rw6KUnwsfAzW39ks5sk4j9gaJpZM4PgaPH
.

I have tested this item ✅ successfully on fa86cfc

We need a second tester here.

@drmenzelit can you please test?

I have tested this item ✅ successfully on fa86cfc

RTC after two successful tests.

Thanks Tony!