Feeling Lucky
?
[#18055] - Side effects Revert Pull?
- Closed
- 22 Sep 2017
- Medium
- Build: staging
- # 18055
Soo I've fixed an issue and made a pull here:
https://github.com/joomla/joomla-cms/pull/18054/files
But this issue was caused by the pull here:
#12220
Whilst trying to improve performance and have strict php checks i.e. === 'true'. This is failing and will be failing on all of changes within @frankmayer's pull that are strict checking against elements, since it is still simpleXML.
We either need to update all comparisons which have gone strict against simplexml values by setting they are strings first before comparing. or revert the pull.
@mbabker for your review please.
joomla-cms-bot
- | Labels |
Added:
?
|
||
franz-wohlkoenig
- | Category | ⇒ | Code style |
| Status | New | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-09-22 08:48:55 |
| Closed_By | ⇒ | tonypartridge |