avatar tonypartridge
21 Sep 2017

Soo I've fixed an issue and made a pull here:

But this issue was caused by the pull here:

Whilst trying to improve performance and have strict php checks i.e. === 'true'. This is failing and will be failing on all of changes within @frankmayer's pull that are strict checking against elements, since it is still simpleXML.

We either need to update all comparisons which have gone strict against simplexml values by setting they are strings first before comparing. or revert the pull.

@mbabker for your review please.

avatar tonypartridge tonypartridge - open - 21 Sep 2017
avatar joomla-cms-bot joomla-cms-bot - change - 21 Sep 2017
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 21 Sep 2017
avatar franz-wohlkoenig franz-wohlkoenig - change - 22 Sep 2017
Category Code style
avatar tonypartridge tonypartridge - change - 22 Sep 2017
Status New Closed
Closed_Date 0000-00-00 00:00:00 2017-09-22 08:48:55
Closed_By tonypartridge
avatar tonypartridge tonypartridge - close - 22 Sep 2017

Add a Comment

Login with GitHub to post a comment