Please add more information to your issue. Without test instructions and/or any description we will close this issue within 4 weeks. Thanks.
This is an automated message from the J!Tracker Application.

How about changing End to Finish to be consistent elsewhere like Finish Publishing?

Thanks for working on it to everybody who is joining this issue.
I am not a programmer or developer, so I can only watch and read.
Unfortunately it was not a part of Joomla! 3.8.0, I hope it will be part of one of the first Joomla! 3.8.x releases in the future.

In the Featured tooltip, seconds is displayed, but not in the Publishing tooltip. To be consistent, do not display the seconds.

Installation SQLs have to be updated with the new columns.

Is the #__content_frontpage table really needful (performace issues)? Why you don't use the field #__content.featured to store the ordering info?

Please, remove the tag "Test instructions missing"

done

@brianteeman Tag "Test instructions missing" is shown at Issue Tracker.

@franz-wohlkoenig I only have access to change it on github

thanks for Info, @brianteeman. As i can't too at Tracker Tag remains.

Are there plans to introduce this issue to a new release of Joomla! 3.8?
Or will this be developped for a later release like 3.9 or 4?

Because it is a new feature it can't go into a 3.8.x release so it has to wait for 3.9.

I agree with the comment @alikon made, "featured_up" and "featured_down" fields should go into the "#__content_frontpage" table.

Many people would be happy with this feature.
After installation, I get an error 500 though:

Unknown column 'a.featured_up' in 'field list'

I have tested this item 🔴 unsuccessfully on 40bb8bd

Please, add the two fields featured_up and featured_down to the table #__content. You can use the sql file administrator/components/com_admin/sql/updates/mysql/3.8.0-2017-09-21.sql

Hi to all the people who are working for this new feature.
What is the status now?
Will this feature be a part of Joomla! 3.9 ?

Hello, I still hope this new feature will be part of Joomla! soon.
Can anyone tell me the status of developing this?

@WoodyF4u there is one unsuccessfully Test, but every Pull Request need at least 2 successfully Tests before a Maintainer decide if PR get merged.

currently it has no successful tests

I am not a programmer or developer, so I can only watch and read.

@WoodyF4u you can test - i'm also no Developer;-)

Edit: How to test

I have tested this item 🔴 unsuccessfully on 4f06f6d

at index.php?option=com_content got 500 - Unknown column 'a.featured_up' in 'field list' Unknown column 'a.featured_up' in 'field list':

Hello,
Today I installed Joomla! 4.0 alpha 5.
I hoped to see the new feature in this release.
But I can set an article as featured, but there are no fields to set the start and stop moments for publishing as featured.

So can anyone tell me how I can

test this new feature>

@WoodyF4u the Pull Request by @eshiol is for Joomla 3. As you can read above this PR needs 2 successfully Tests as next Step.

for Test this PR needs also an Update (Comment)

at least, 19 files to check if not update.

The patch tester component doesn't run the update sql files. You have to manually run the file administrator/components/com_admin/sql/updates//3.8.0-2017-09-21.sql to modify the database structure.

I have tested this item 🔴 unsuccessfully on 4f06f6d

Modified database according to instructions.

Tried to apply patch.

Error: The file marked for modification does not exist: administrator/components/com_content/helpers/html/contentadministrator.php

hello.. i am looking for this feature.. and hopes its gettings build in the core joomla.
for now i am happy to test this feature.. but tell my what to do...

@crommie
You are testing on a 4.0 where that file does not exist indeed.
It does in staging (3.8.x).

What you have to do for testing this pr: Testing Instructions.

• Install nightly build of Joomla 3.9 (Important!) with testing sample data (I used Learn Joomla)
  https://developer.joomla.org/nightly-builds.html
  One can't test with 3.8.12 without additional steps because of changes of the database by other PRs!
• Install "Joomla Patch Tester" https://github.com/joomla-extensions/patchtester/releases
  (I use Patch Tester 3.0.0 Beta 4)
• "Fetch Data" in Joomla Patchtester.
• Search for 18052 and Apply this patch.

Before you do anything else:

• Go to Extensions > Manage > Database and click the Fix button!

• Now you can follow the Testing Instructions of first post by @eshiol

• Be aware of the timezone shift of your server settings that may lead to not displayed articles. Change the hour value of "Start Featured" accordingly.

okay.. i followed the steps using..

1. Install nightly build of Joomla 3.9 (Important!) with testing sample data (I used Learn Joomla)

2. Install "Joomla Patch Tester" https://github.com/joomla-extensions/patchtester/releases

3. "Fetch Data" in Joomla Patchtester.

4. Search for 18052 and Apply this patch.

5. Go to Extensions > Manage > Database and click the Fix button!

6. Skipped: i did not find the file: modify the database structure using the file 3.8.0-2017-09-21.sql
   7 create 5 articles:
   article 1, not featured
   article 2, featured, featured_up = null, featured_down = null
   article 3, featured, featured_up = tomorrow, featured_down = null
   article 4, featured, featured_up = null, featured_down = yesterday
   article 5, featured, featured_up = yesterday, featured_down = tomorrow

7. Create an Articles » Featured Articles menu item
   Results:
   the results are as the discribed.. only 2 documents are published..

@johanpeters
Go to patch tester and click the orange button in column "Issue Tracker". There after login:

I have tested this item ✅ successfully on d079f14

okay.. i followed the steps using..

Install nightly build of Joomla 3.9 (Important!) with testing sample data (I used Learn Joomla)

Install "Joomla Patch Tester" https://github.com/joomla-extensions/patchtester/releases

"Fetch Data" in Joomla Patchtester.

Search for 18052 and Apply this patch.

Go to Extensions > Manage > Database and click the Fix button!

Skipped: i did not find the file: modify the database structure using the file 3.8.0-2017-09-21.sql
7 create 5 articles:
article 1, not featured
article 2, featured, featured_up = null, featured_down = null
article 3, featured, featured_up = tomorrow, featured_down = null
article 4, featured, featured_up = null, featured_down = yesterday
article 5, featured, featured_up = yesterday, featured_down = tomorrow

Create an Articles » Featured Articles menu item
Results:
the results are as the discribed.. only 2 documents are published..

@ReLater ..thanks.. i updated and test this..
thanks..

Functionality works 100% from backend.. frontend is (not) implemented

frontend is (not) implemented

Maybe I just don't understand because of the "(not)". I see the new fields in tabulator Publishing of frontend edit view as Super User.

On the frontendI do see the default feature option yes/no..But when selecting yes i dont get the xtra start and finish feature publishing date fields.

Verzonden vanaf mijn Samsung Galaxy-smartphone.
-------- Oorspronkelijk bericht --------Van: ReLater notifications@github.com Datum: 09-10-18 14:35 (GMT+01:00) Aan: joomla/joomla-cms joomla-cms@noreply.github.com Cc: johanpeters j.peters@itics.nl, Mention mention@noreply.github.com Onderwerp: Re: [joomla/joomla-cms] [New Feature] Schedule featured articles #13596 (#18052)

frontend is (not) implemented

Maybe I just don't understand because of the "(not)". I see the new fields in tabulator Publishing of frontend edit view as Super User.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/joomla/joomla-cms","title":"joomla/joomla-cms","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/joomla/joomla-cms"}},"updates":{"snippets":[{"icon":"PERSON","message":"@ReLater in #18052: \u003e frontend is (not) implemented\r\n\r\nMaybe I just don't understand because of the "(not)". I see the new fields in tabulator Publishing of frontend edit view as Super User."}],"action":{"name":"View Pull Request","url":"https://github.com/joomla/joomla-cms/pull/18052#issuecomment-428174317"}}}
[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com//pull/18052#issuecomment-428174317",
"url": "https://github.com//pull/18052#issuecomment-428174317",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
},
{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "Re: [joomla/joomla-cms] [New Feature] Schedule featured articles #13596 (#18052)",
"sections": [
{
"text": "",
"activityTitle": "ReLater",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@ReLater",
"facts": [

]
}
],
"potentialAction": [
{
"name": "Add a comment",
"@type": "ActionCard",
"inputs": [
{
"isMultiLine": true,
"@type": "TextInput",
"id": "IssueComment",
"isRequired": false
}
],
"actions": [
{
"name": "Comment",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n"commandName": "IssueComment",\n"repositoryFullName": "joomla/joomla-cms",\n"issueId": 18052,\n"IssueComment": "{{IssueComment.value}}"\n}"
}
]
},
{
"name": "Close pull request",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n"commandName": "PullRequestClose",\n"repositoryFullName": "joomla/joomla-cms",\n"pullRequestId": 18052\n}"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com//pull/18052#issuecomment-428174317"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n"commandName": "MuteNotification",\n"threadId": 260025832\n}"
}
],
"themeColor": "26292E"
}
]

i don't see it in frontpage.. seee image.

@johanpeters
My fault. Yes, you're right. You should send an additional unsuccessful test then.

If i read the test criteria.. the test passes.Because its completly focused on the backend.
But the feature schould be on the frontend also.. 
Question is.. is frontend included .. en test fail.. or not included and test pass..
Of not oncluded tjen a new version schould be created to enable frontend.. but this can then be implemented as is.. a lot of people are waiting for this feature.. 
Next version include frontend.. And maybe a default to set .. if featured is yes then default 7 days.. or something

Verzonden vanaf mijn Samsung Galaxy-smartphone.
-------- Oorspronkelijk bericht --------Van: ReLater notifications@github.com Datum: 09-10-18 16:43 (GMT+01:00) Aan: joomla/joomla-cms joomla-cms@noreply.github.com Cc: johanpeters j.peters@itics.nl, Mention mention@noreply.github.com Onderwerp: Re: [joomla/joomla-cms] [New Feature] Schedule featured articles #13596 (#18052)
@johanpeters

My fault. Yes, you're right. You should send an additional unsuccessful test then.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/joomla/joomla-cms","title":"joomla/joomla-cms","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/joomla/joomla-cms"}},"updates":{"snippets":[{"icon":"PERSON","message":"@ReLater in #18052: @johanpeters \r\nMy fault. Yes, you're right. You should send an additional unsuccessful test then."}],"action":{"name":"View Pull Request","url":"https://github.com/joomla/joomla-cms/pull/18052#issuecomment-428219855"}}}
[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com//pull/18052#issuecomment-428219855",
"url": "https://github.com//pull/18052#issuecomment-428219855",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
},
{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "Re: [joomla/joomla-cms] [New Feature] Schedule featured articles #13596 (#18052)",
"sections": [
{
"text": "",
"activityTitle": "ReLater",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@ReLater",
"facts": [

]
}
],
"potentialAction": [
{
"name": "Add a comment",
"@type": "ActionCard",
"inputs": [
{
"isMultiLine": true,
"@type": "TextInput",
"id": "IssueComment",
"isRequired": false
}
],
"actions": [
{
"name": "Comment",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n"commandName": "IssueComment",\n"repositoryFullName": "joomla/joomla-cms",\n"issueId": 18052,\n"IssueComment": "{{IssueComment.value}}"\n}"
}
]
},
{
"name": "Close pull request",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n"commandName": "PullRequestClose",\n"repositoryFullName": "joomla/joomla-cms",\n"pullRequestId": 18052\n}"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com//pull/18052#issuecomment-428219855"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n"commandName": "MuteNotification",\n"threadId": 260025832\n}"
}
],
"themeColor": "26292E"
}
]

I have tested this item 🔴 unsuccessfully on d079f14

New options aren't displayed in front-end even if a Super User is editing an article.

I have tested this item 🔴 unsuccessfully on d079f14

The test for backend is complete succesfully..
but when create or edit an article from frontend with super user rights you don't see the start end stop feature date field.
on non features articles and on features articles.

@eshiol.. was it developed to work on frontend also.. if yes then test failed.
If no.. then test is succesful

The pull request is not designed to work on the frontend, but I think it should be. I'll write the code as soon as possible.

@eshiol Greate.. a frontend integration would be greate..
@ReLater
okay.. than i will change the test results to succes.. it works like design..
@ReLater can you change your result also..

I have tested this item ✅ successfully on d079f14

the current implementation works .. there is no frontend integration build in..

I have tested this item ✅ successfully on d079f14

the current implementation works .. there is no frontend integration build in..

frontend code added

I have tested this item ✅ successfully on 3cecb32

succesfull test incl frontend..
request: on frontend when selecting featured Yes then first the start / end Featured date and below the start/stop publisher date.

@eshiol .. tested Okay.. can you take a look at my request.. (other order of start/end date fields on frontend).

@eshiol .. tested Okay.. can you take a look at my request.. (other order of start/end date fields on frontend).

Modifications in en-GB.lib_joomla.ini have to be done both in administrator and site files.

administrator/components/com_admin/sql/updates/mysql/3.8.0-2017-09-21.sql has Macintosh EOL.
Should be UNIX.
EDIT: Looks this is solved.

Also, looks like there is an issue with EOLs in
/Applications/MAMP/htdocs/trunkgitnew/tests/unit/schema/sqlsrv.sql
But this could be unrelated to this patch. Has to be corrected imho

@eshiol .. tested Okay.. can you take a look at my request.. (other order of start/end date fields on frontend).

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18052.

fixed

I have tested this item ✅ successfully on 3cecb32

Order frontend checked and okay...
Greate... i dont see any issues anymore.. so if its on me.. lets go public..

translation in dutch on request.. ;-)

I have tested this item ✅ successfully on 3cecb32

Order frontend checked and okay...
Greate... i dont see any issues anymore.. so if its on me.. lets go public..

translation in dutch on request.. ;-)

Note: al the test that i did whas without the use of the sql file...

Note: al the test that i did whas without the use of the sql file...

@johanpeters
It is NOT finished. See my comments above.

@infograph..
Are you ref. to the sql file issues?.
I have tested it withoud the sql file as part of this patch test describtion because i could not find it.. what schould be the fu tion of the sql file? The schedule feature works for me as aspected..

Modifications in en-GB.lib_joomla.ini have to be done both in administrator and site files.

featured up/down is a feature of com_content, I think en-GB.com_content.ini is better than en-GB.lib_joomla.ini, imho

I have tested it withoud the sql file as part of this patch test describtion because i could not find it.. what schould be the fu tion of the sql file?

To update the database with the two new columns needed to make this feature work. In one of your earlier comments, you noted you "Go to Extensions > Manage > Database and click the Fix button!", in which case with the patch applied the relevant SQL file would've been run and you wouldn't need to manually do anything.

As for finding it, if you click the files tab on any GitHub pull request, the list of files and the paths match up exactly to where it should exist in a Joomla site. So if you had the patch applied and didn't have a administrator/components/com_admin/sql/updates/<database>/3.8.0-2017-09-21.sql file in your site when you hit the fix button then the new database columns couldn't have been added to the site and testing the feature wouldn't have worked as you would eventually have run into a SQL error.

@mbabker .. thanks for the explanation..
in the first installation i did hit the fix Button after installation. If that wil run the sql file than i have used it.. the tests i did after that the only thing i did was remove the patch and reinstall the latest patch version.. no fix button.. but simple test and check of the function was working incl. the add functionality..

Because the database columns were still there. Patch tester doesn't ever touch the database schema and there is no rollback capability for schema changes.

@eshiol
I think you did not understand.

This PR adds strings to https://github.com/joomla/joomla-cms/pull/18052/files#diff-fa3a45e6746f58d4a54e42207ee8f4ad

That is OK as these strings could indeed be used for example for Contacts which has also a featured status.
BUT, therefore, the SAME modifications should be done in the frontend file!
ROOT/language/en-GB/en-GB.lib_joomla.ini
as these 2 files should be in sync.

@infograf768
You are right. Fixed.

Hello.. what is the current status of this feature.. when will this be released or build in the core joomla?..
i need this feature for multiple website's.. as far as i can see and have tested it it works for me..

greetings.

Hello.. what is the current status of this feature.. when will this be released or build in the core joomla?..
i need this feature for multiple website's.. as far as i can see and have tested it it works for me..

greetings.

@johanpeters 3.x series has a feature freeze, so this PR has to be ported to J4 and maybe get included in in Joomla 4.0

@HLeithner you really need to announce (and define) this feature freeze and then review and update ALL the existing issues and PR.

No point in having open feature PR for the J3 branch
No point in having open feature Issues for the J3 branch

AND ensure that all new PR and Issues for the J3 branch are commented on appropriately - just leaving them there just creates frustration and WASTES TIME for everyone

@brianteeman thats not my decision thats from the last Production meeting Report:
https://volunteers.joomla.org/departments/production/reports/936-production-meeting-december-2018

• There was a discussion about . It was voted to reject this and stick to the current plan of having 3.10 as the bridge release for Joomla 4

Also reflected in the Roadmap https://developer.joomla.org/roadmap.html

• Note: Joomla! 3.9 will be the last 3.x release with new features, all new features have to go into Joomla! 4.

I'm not in the position to say that this is valid for all PR's so maybe there are PR's that gets into a patch level which adds a small feature.

My comment may was not detailed enough, sry for this.

There is a missing word or phrase in the minutes that says what the proposal was that was discussed - the community are not mind readers

maybe @wilsonge can tell us more about this. I'm not part of the production team atm.

We discussed this in the last days in the maintainers chat and George wanted to see with Sandra to write something.

@Bakual thank you - I had given up ever getting a reply from @wilsonge

Let's get this rebased onto j4 and get a fresh test. seems like a nice feature :)

Set to "closed" on behalf of @alikon by The JTracker Application at issues.joomla.org/joomla-cms/18052

As we are in feature freeze
all new features have to go into Joomla! 4.

Please rebase this nice feature in J4

As we are in feature freeze
all new features have to go into Joomla! 4.

Please rebase this nice feature in J4

PR #25979 rebased for J4