[#18043] - Check if array property exists.
- Closed
- 26 Sep 2017
- Medium
- Build: staging
- # 18043
- Diff
- jeppech:patch-1
- Pending hound Hound is busy reviewing changes... Details
User tests: Successful: Unsuccessful:
Prevents throwing Notice: Trying to get property of non-object in libraries/src/Component/Router/Rules/MenuRules.php on line 183
| Category | ⇒ | Libraries |
| Status | New | ⇒ | Pending |
I'm sorry, but I don't know how to answer that. I'm unfamiliar with how Joomla works, so I wouldn't know if it's a configuration issue, which for me, it seems not.
Our company website, throws these notices: https://jeppe.ch/i/3RsAkepH.png - So this PR is just a simple check for, if an array property exists, as the title says.
@franz-wohlkoenig This is a legitimate fix.
@franz-wohlkoenig I don't see how this is not an issue, as Joomla obviously fails to check if an array property exists.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-09-26 15:28:01 |
| Closed_By | ⇒ | franz-wohlkoenig |
Set to "closed" on behalf of @franz-wohlkoenig by The JTracker Application at issues.joomla.org/joomla-cms/18043
closed as having Pull Request #18123
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18043.
@franz-wohlkoenig this is a pull request as well
so theres a Pull Request for a Pull Request?
looks like it
| Status | Closed | ⇒ | Pending |
| Closed_Date | 2017-09-26 15:28:01 | ⇒ | |
| Closed_By | franz-wohlkoenig | ⇒ |
| Status | Pending | ⇒ | New |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ |
| Status | New | ⇒ | Pending |
Set to "open" on behalf of @franz-wohlkoenig by The JTracker Application at issues.joomla.org/joomla-cms/18043
@brianteeman thanks for Info.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-09-26 19:31:55 |
| Closed_By | ⇒ | franz-wohlkoenig |
| Closed_Date | 2017-09-26 19:31:55 | ⇒ | 2017-09-26 19:31:56 |
| Closed_By | franz-wohlkoenig | ⇒ | joomla-cms-bot |
Set to "closed" on behalf of @franz-wohlkoenig by The JTracker Application at issues.joomla.org/joomla-cms/18043
closed as duplicate Pull Request.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18043.
Can this be reopened? We might as well have 3 solutions to the same problem open.
Can't be reopened, source branch for the PR has been deleted.
can you please give more Information what your Pull Request is for also Test Instructions?