J4 Issue ?
avatar kasvith
kasvith
21 Sep 2017

Steps to reproduce the issue

With the New Media Manager you don't really have a specific folder for images so the option that is related to this can be removed safely.

image

New implementation supports multiple folders up to unlimited numbers.
image

Expected result

Actual result

System information (as much as possible)

Additional comments

Documentation changes might required

avatar kasvith kasvith - open - 21 Sep 2017
avatar joomla-cms-bot joomla-cms-bot - change - 21 Sep 2017
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 21 Sep 2017
avatar kasvith kasvith - change - 21 Sep 2017
The description was changed
avatar kasvith kasvith - edited - 21 Sep 2017
avatar franz-wohlkoenig franz-wohlkoenig - change - 21 Sep 2017
Category com_media
avatar brianteeman
brianteeman - comment - 29 Sep 2017

Can it really be removed safely? That would mean that any user who did not use the default would have to go into the plugin and apply the settings there.
Also (and i might be wrong) but isnt the value of that option used in extensions - so simply removing it would be a hard bc break

avatar franz-wohlkoenig franz-wohlkoenig - change - 29 Sep 2017
Status New Information Required
avatar kasvith
kasvith - comment - 1 Oct 2017

then we have to mark this as to be removed in future releases. we need to deprecate it because it is not used in Joomla! 4 Media Manager at all. People will get confused by this

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 1 Oct 2017

@wilsonge as Release Lead on above Comment?

avatar laoneo
laoneo - comment - 1 Oct 2017

I guess we can remove the files setting, don't know what this setting is for at all. The question is more where an extension should place it's images? If it is in /images/com_foo then we probably need to leave the images setting. If it should be /media/com_foo/images then we can remove images setting too.

avatar brianteeman
brianteeman - comment - 1 Oct 2017

Its not about where they should store the images in the future (or past) its about is the setting used by extensions now. If it is then we need a way to deprecate the setting AND a new way for extensions to reference it.

For example if an extension is expecting to put files in images/com_foo but images is not "mounted" is that a problem?

avatar dgt41
dgt41 - comment - 1 Oct 2017

a new way for extensions to reference it.

This should be possible through the API something like get the com_media params. In essence every local adapter needs to save the relative path/folder to an array named eg localPaths

For example if an extension is expecting to put files in images/com_foo but images is not "mounted" is that a problem?

I think this will not work if the folder is not mounted

@laoneo @kasvith ??

avatar kasvith
kasvith - comment - 1 Oct 2017

you can put whatever you want in images/com_foo, Local Adapter is like an interface, you can access any folder without it. Basically if someone uses these features we have lot of time to warn them and tell to use modern way.

avatar laoneo
laoneo - comment - 2 Oct 2017

It can become a problem when the extension uses a media form field. It always shows only folders below the image setting folder (https://github.com/joomla/joomla-cms/blob/staging/libraries/src/Form/Field/MediaField.php#L232). So we kind of need the images setting still intact and need to make sure that images is always mounted. Probably we need to serve the folder with that setting always when the media manager is opened trough a media form field.

avatar franz-wohlkoenig franz-wohlkoenig - change - 22 Oct 2017
Status Information Required Discussion
avatar franz-wohlkoenig franz-wohlkoenig - change - 12 Dec 2017
Status Discussion Closed
Closed_Date 0000-00-00 00:00:00 2017-12-12 08:35:13
Closed_By franz-wohlkoenig
avatar joomla-cms-bot joomla-cms-bot - change - 12 Dec 2017
Closed_By franz-wohlkoenig joomla-cms-bot
avatar joomla-cms-bot joomla-cms-bot - close - 12 Dec 2017
avatar joomla-cms-bot
joomla-cms-bot - comment - 12 Dec 2017
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 12 Dec 2017

@kasvith: according to @laoneo closing this Issue, please open a new one at https://github.com/joomla-projects/media-manager-improvement.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18035.

avatar laoneo
laoneo - comment - 12 Dec 2017

This one can be left open, as we tried to get feedback what to do with the settings which do become obsolete with the new MM.

avatar wilsonge wilsonge - change - 12 Dec 2017
Status Closed New
Closed_Date 2017-12-12 08:35:13
Closed_By joomla-cms-bot
avatar wilsonge wilsonge - reopen - 12 Dec 2017
avatar franz-wohlkoenig franz-wohlkoenig - change - 22 Dec 2017
Status New Discussion
avatar brianteeman brianteeman - labeled - 25 Mar 2018
avatar brianteeman
brianteeman - comment - 23 May 2018

@laoneo reminder

avatar laoneo
laoneo - comment - 24 May 2018

Guess we will not get much more feedback. Closing it.

avatar laoneo laoneo - change - 24 May 2018
Status Discussion Closed
Closed_Date 0000-00-00 00:00:00 2018-05-24 16:59:36
Closed_By laoneo
Labels Added: J4 Issue
avatar laoneo laoneo - close - 24 May 2018
avatar brianteeman
brianteeman - comment - 24 May 2018

So I hope it will be actioned now

Add a Comment

Login with GitHub to post a comment