? Pending

User tests: Successful: Unsuccessful:

avatar ciar4n
ciar4n
20 Sep 2017

Pull Request for Issue # .

Summary of Changes

Allows the use of languages strings within #15939

Testing Instructions

Add the following to an XML and ensure it renders the langauge string correctly..

<field
	name="crop_width"
	type="text"
	addonBefore="PLG_MEDIA-ACTION_CROP_PARAM_WIDTH"
	addonAfter="px"
	pattern="\d*\.?\d*"
	label="PLG_MEDIA-ACTION_CROP_PARAM_WIDTH"
/>

Expected result

image

Actual result

Documentation Changes Required

@Sandra97 If we could get the addonBefore/addonAfter attributes added to https://docs.joomla.org/Text_form_field_type that would be great!)

avatar joomla-cms-bot joomla-cms-bot - change - 20 Sep 2017
Category Layout
avatar ciar4n ciar4n - open - 20 Sep 2017
avatar ciar4n ciar4n - change - 20 Sep 2017
Status New Pending
avatar wilsonge wilsonge - change - 20 Sep 2017
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-09-20 16:27:49
Closed_By wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 20 Sep 2017
avatar wilsonge wilsonge - merge - 20 Sep 2017
avatar Sandra97
Sandra97 - comment - 23 Sep 2017

@ciaran, JDocs is a wiki, eveybody can edit it. Could you please make the changes? Thanks!

avatar ciar4n
ciar4n - comment - 26 Sep 2017

@Sandra97 Cool... I somehow managed not to know JDocs was a wiki! As this is only for Joomla 4, I presume I wait until the J4 docs are up.

avatar Sandra97
Sandra97 - comment - 27 Sep 2017

@ciar4n You can add whatever you want about J4 on JDocs as we already have a category for J4: https://docs.joomla.org/Category:Joomla!_4.x

avatar dgt41
dgt41 - comment - 27 Sep 2017

@Sandra97 so J4 docs will be on wiki? why? I mean we can leave the old stuff there and move the rest to GitHub pages (markdown is ok for all of us I guess)

avatar mbabker
mbabker - comment - 27 Sep 2017

If you can come up with a way where they can be easily edited by anyone and translations are maintainable (a serious proposal) then we can consider it. Otherwise, we have a wiki and have had it for a long time, so it's going to be used until such a time that it can be efficiently replaced.

avatar mbabker
mbabker - comment - 27 Sep 2017

(FWIW we basically are using GitHub for Framework v2 docs, but that is also more geared toward devs who would be more comfortable contributing in Markdown than someone of less technical skill; there are also other options where you can parse stuff into a website without using GitHub pages 100%, see Symfony and Laravel as examples, but their content is also heavily developer oriented and not translated)

avatar Sandra97
Sandra97 - comment - 27 Sep 2017

In addition to what Michael mentioned, don't forget also that JDocs is one of the most visited of our properties and the one with the best ranking on Google.

avatar dgt41
dgt41 - comment - 27 Sep 2017

Let’s leave this talk for JWC then

Add a Comment

Login with GitHub to post a comment