[#18007] - PHP 7.2 Removed mcrypt
- Closed
- 30 Sep 2017
- Medium
- Build: staging
- # 18007
We have checks in core regarding the presence of the mcrypt extension. Since that has been dropped in PHP 7.2, we need to update core to account for this.
| Labels |
Added:
?
|
||
| Category | ⇒ | External Library |
I'm pretty sure use of it is phased out, or in optional paths (i.e. the FOF and core encryption adapters). But, we still have some code checks in places that should probably be dropped (or if we want to check for presence at least wrap it in a PHP version conditional).
joomla-cms/installation/model/setup.php
Lines 299 to 304 in dc12100
didnt the fof update back in 2016 remove it?
sorry i was wrong on that.
The hard dependency was removed. The mcrypt adapter is still there.
All of our mcrypt code paths are still usable, even on PHP 7.2 if you install the PECL extension (why you'd want to is beyond me but hey, more power to you). Those two links I pointed out above though are system health checks that make an implication that mcrypt should be installed. Those are the types of things we need to deal with at this point. It's not about functionality at this point really, it's more about what we're communicating to users in validating their server is "good" to run the software.
Ok. I will take a look at doing a pr for that then
| Closed_By | franz-wohlkoenig | ⇒ | joomla-cms-bot |
| Status | New | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-09-30 13:05:36 |
| Closed_By | ⇒ | franz-wohlkoenig |
Set to "closed" on behalf of @franz-wohlkoenig by The JTracker Application at issues.joomla.org/joomla-cms/18007
closed as having Pull Request #18169
Thanks for Hint @Quy
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18007.
Although we have the checks didnt we already remove any usage of mcrypt? I thought the only place it was used was in tfa and we stopped that back with 3.6.3