[#17975] - [Regression] Fix being able to add custom tags in a form field when explicitely denied
- Closed
- 22 Sep 2017
- Medium
- Build: staging
- # 17975
- Diff
- wilsonge:fix-deny-custom-tags
- Pending hound Hound is busy reviewing changes... Details
User tests: Successful: Unsuccessful:
Fixes regression in 5aa724a#diff-069d36e84093f570923bd7b0459eac93R257
Summary of Changes
You can explicitly stop new tags from being created in the tags form field, which is useful when for example you want people to only be able to select from existing tags in a module. However we have broken this functionality, by doing an explicit typecheck of a string against a SimpleXMLElement (which fails all the time allowing you to create tags all the time)
Testing Instructions
Find a type="tag" field in the CMS and add modify it to have custom="deny" in it's definition. For example:
<field
name="tags"
type="tag"
label="JTAG"
description="JTAG_DESC"
multiple="true"
custom="deny"
/>
Expected result
You can't create tags in the field
Actual result
You can before the patch. You cannot afterwards
Documentation Changes Required
N/A - fixes regression
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Status | New | ⇒ | Pending |
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-09-22 10:16:43 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
Closing as covered by #18061