[#17970] - Text separator with menu item params
- Fixed in Code Base
- 10 Oct 2017
- Medium
- Build: staging
- # 17970
- Diff
- izharaazmi:menu-separator
User tests: Successful: Unsuccessful:
Pull Request for Issue #16198.
Summary of Changes
Added setting to choose whether the user wants the "separator" type menu item to be displayed as standard separator (horizontal line) or labelled separator (with title text).
For B/C the titles containing only dashes and spaces will still be displayed as standard separator this can be changed in 4.0 if deemed fit. This note is included in the field description tip.
Testing Instructions
- Apply patch
- The menu item separators should display exactly the same as before this patch. Check separators under "menu" dropdown.
- Create a new custom menu for backend and add some menu items. Also add separators between items.
- When creating separator menu items, you should be able to enter any title for it and choose whether to use title as label for the separator or not.
- Switch to this custom menu in menu module settings. Your menu should be displayed correctly with appropriate type of separators.
Documentation Changes Required
Need to add information about using separator menu items in admin menu manager.
Fixes #16198.
joomla-cms-bot
- | Category | ⇒ | Administration com_menus Language & Strings Modules Libraries |
| Status | New | ⇒ | Pending |
| Labels |
Added:
?
?
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17970.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17970.
| Status | Pending | ⇒ | Ready to Commit |
RTC after two successful tests.
@franz-wohlkoenig please remove RTC until the 2 outstanding issues are resolved
| Labels |
Added:
?
|
||
@brianteeman 2 new Tests? Ready to Commit-Label removed.
| Status | Ready to Commit | ⇒ | Pending |
Just code style so no need for new tests
| Status | Pending | ⇒ | Ready to Commit |
RTC after two successful tests.
Merge conflicts
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-10-10 11:45:34 |
| Closed_By | ⇒ | mbabker |
I have tested this item✅ successfully on 8033d41
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17970.