[#17951] - Issue#17932 -- Inconsistent suffix while duplicating modules
- Closed
- 6 May 2018
- Medium
- Build: staging
- # 17951
- Diff
- akritianand:issue#17932
- Success hound No violations found. Woof! Details
- Failure continuous-integration/drone/pr the build failed Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #17932 .
Summary of Changes
Originally: Duplicate created module (2), module (3)... and Save & Copy created module (copy)
Now: Duplicate and Save & Copy both create module (2), module (3)...
However titles created by both these buttons are independent, i.e., duplicating module will give module (1) and Save & Copy of module will also give module (1) (irrespective of whether it exists or not).
Testing Instructions
In Module Manager select/check a module.
-
Click button Duplicate. -
The title of copy has a postfix (2). -
Now open a module by clicking the title link. -
Click button Save as Copy. -
The title of copy gets a postfix (copy).
Expected result
Uniform module title.
Actual result
As mentioned above
Documentation Changes Required
None.
| Category | ⇒ | Administration com_modules JavaScript |
| Status | New | ⇒ | Pending |
I have a doubt in syntax.
I am trying to execute this:
$var = $data['title'];
$db = $this->getDbo();
$query = $db->getQuery(true);
$query
->select('title')
->from('#__modules')
->where('title = '. $var);
$db->setQuery($query);
try
{
$db->execute();
while($row = $db->loadRowList()) {
//some code
}
}
catch (RuntimeException $e)
{
$this->setError($e->getMessage());
return false;
}
Now $var here is modulename (1). But it shows this error when excecuting: Save failed with the following error: SQLSTATE[42000]: Syntax error or access violation: 1305 FUNCTION joomla.modulename (1) does not exist.
Can you tell me where I am wrong?
Thank you.
In fact it is treating modulename (1) as a function. So if I remove (1) I get a different error: SQLSTATE[42S22]: Column not found: 1054 Unknown column 'modulename' in 'where clause'. :/
- Commented code shouldn't be committed, that's what version control is for
? - Are the calendar JavaScript changes related to this?
@akritianand you need to use a separate branch for each pull request so that a PR only contains the changed files for this PR
| Category | Administration com_modules JavaScript | ⇒ | Administration com_admin com_contact com_finder com_menus com_modules com_plugins com_users Language & Strings Templates (admin) Repository Front End com_content |
| Labels |
Added:
?
|
||
@brianteeman Oh sorry. I reverted all my changes. Now my pull request only contains the changes for this PR.
| Labels |
Added:
?
|
||
@akritianand as you can see that didnt work as it is now showing 195 changed files
@brianteeman I updated my branch with the latest joomla repository. So that there are no conflicts.
| Closed_Date | 2018-05-06 17:31:10 | ⇒ | 2018-05-06 17:31:11 |
| Closed_By | Quy | ⇒ | joomla-cms-bot |
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-05-06 17:31:10 |
| Closed_By | ⇒ | Quy |
Set to "closed" on behalf of @Quy by The JTracker Application at issues.joomla.org/joomla-cms/17951
This is no longer an issue.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17951.
I have tested this item? unsuccessfully on af24b73
Web Links (2)(works)Web Linksand clickSave as Copygot 3rd ModuleWeb Links (2)(wrong):This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17951.