? Pending

User tests: Successful: Unsuccessful:

avatar laoneo
laoneo
12 Sep 2017

Summary of Changes

I can't save an article on the front end on the current staging branch because of the error:
Call to undefined method Joomla\CMS\Editor\Editor::save()

Testing Instructions

Edit an article on the front end.

Expected result

Article edit form opens and article can be edited.

Actual result

Error is displayed and article can't be edited.

avatar joomla-cms-bot joomla-cms-bot - change - 12 Sep 2017
Category Libraries
avatar laoneo laoneo - open - 12 Sep 2017
avatar laoneo laoneo - change - 12 Sep 2017
Status New Pending
avatar mbabker
mbabker - comment - 12 Sep 2017

Ping @dgt41 as this involves code removed from the editor and plugins...

avatar dgt41
dgt41 - comment - 12 Sep 2017
avatar laoneo laoneo - change - 12 Sep 2017
Labels Added: ?
avatar laoneo
laoneo - comment - 12 Sep 2017

@dgt41 I think now we have a BC break here which we probably can avoid with my first suggestion. This code here https://github.com/joomla/joomla-cms/blob/4.0-dev/components/com_content/tmpl/form/edit.php#L35 breaks now in every extension.

avatar laoneo
laoneo - comment - 12 Sep 2017

I'v reverted the save function and marked it as deprecated, which I think is better than having a BC break here.

avatar dgt41
dgt41 - comment - 12 Sep 2017

@laoneo the methods are deprecated since 3.7 and this is a needed B/C break.
The reason is that dropping the support for these old stuff we also enable multi-editors per page.
This is on purpose

EDIT: we can still provide empty function as we're doing in JHtml::behavior, so apps won't crash and burn (though I'm not in favour of doing that)

avatar laoneo
laoneo - comment - 12 Sep 2017

The function in the editors itself but not on the form field.

avatar dgt41
dgt41 - comment - 12 Sep 2017

Let's deprecate it in 3.8/3.9 and remove it in j4. Let's drag less unneeded baggages...

avatar dgt41
dgt41 - comment - 12 Sep 2017

If you want keep this can you always return null?

avatar joomla-cms-bot joomla-cms-bot - change - 12 Sep 2017
Category Libraries Front End com_content Libraries
avatar laoneo
laoneo - comment - 12 Sep 2017

Removed the function as suggested and deprecated the form field function in staging trough pr #17944. Hopefully it will get into 3.8 to have enough time for extension devs to adapt.

avatar wilsonge
wilsonge - comment - 2 Feb 2018

Is this still needed? I know @dgt41 's did a refactor on tiny at some point towards the end of last year and I've slightly lost track

avatar dgt41
dgt41 - comment - 2 Feb 2018

@wilsonge we already deprecated these methods in 3.x but we still need a pr to actually drop them in 4.0. Will do that later on today

avatar laoneo
laoneo - comment - 3 Feb 2018

That's what this pr is doing and the deprecation message is added in the pr #17944. Keep in mind, we talk here about the form field and not the editor itself.

avatar joomla-cms-bot joomla-cms-bot - change - 11 Jun 2018
Category Libraries Front End com_content Libraries
avatar laoneo laoneo - change - 11 Jun 2018
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2018-06-11 09:12:17
Closed_By laoneo
avatar laoneo laoneo - close - 11 Jun 2018

Add a Comment

Login with GitHub to post a comment