If this is indeed incorrect then it needs changing in the sample_blog.sql files as well.

Good point Brian.

I checked the file sample_blog.sql \installation\sql\mysql and found this inconsistency. Created a separate PR (#17929) for that.

but did you check to see if it is wrong when installed that way? the params might be correct in the installation sql files and it is the params that are wrong in the module install method (about to bpoard a plane so i cant check myself)

but did you check to see if it is wrong when installed that way? the params might be correct in the installation sql files and it is the params that are wrong in the module install method (about to bpoard a plane so i cant check myself)

Yes, I did. An image of the menu item created by the system is attached (Step (d) of Testing Instructions.)

Detailed information:

Please note that the Number of Links mentioned is Two ("num_links":2) in the following objects.

(i) Content of the column params in the table _menu. Menu Item created by the installation of Sample Data using the plugin "Sample Data - Blog":

{"layout_type":"blog","show_category_title":0,"num_leading_articles":4,"num_intro_articles":0,"num_columns":1,"num_links":2,"multi_column_order":1,"orderby_sec":"rdate","order_date":"published","show_pagination":2,"show_pagination_results":1,"show_category":0,"info_bloc_position":0,"show_publish_date":0,"show_hits":0,"show_feed_link":1,"menu_text":1,"show_page_heading":0,"secure":0}

(ii) Content of the column params in the table _menu. Menu Item created by the installation of Blog Sample Data while installing Joomla!:

{"layout_type":"blog","show_category_title":"0","show_description":"","show_description_image":"","maxLevel":"","show_empty_categories":"","show_no_articles":"","show_subcat_desc":"","show_cat_num_articles":"","page_subheading":"","num_leading_articles":"4","num_intro_articles":"0","num_columns":"1","num_links":"2","multi_column_order":"1","show_subcategory_content":"","orderby_pri":"","orderby_sec":"rdate","order_date":"published","show_pagination":"2","show_pagination_results":"1","show_title":"","link_titles":"","show_intro":"","show_category":"0","link_category":"","show_parent_category":"","link_parent_category":"","info_bloc_position":"0","show_author":"","link_author":"","show_create_date":"","show_modify_date":"","show_publish_date":"0","show_item_navigation":"","show_vote":"","show_readmore":"","show_readmore_title":"","show_icons":"","show_print_icon":"","show_email_icon":"","show_hits":"0","show_noauth":"","show_feed_link":"1","feed_summary":"","menu-anchor_title":"","menu-anchor_css":"","menu_image":"","menu_text":1,"page_title":"","show_page_heading":0,"page_heading":"","pageclass_sfx":"","menu-meta_description":"","menu-meta_keywords":"","robots":"","secure":0}

(iii) Content in the file sample_blog.sql that is available in the directory \installation\sql\mysql

(101, 'mainmenu', 'Home', 'home', '', 'home', 'index.php?option=com_content&view=category&layout=blog&id=9', 'component', 1, 1, 1, 22, 0, '0000-00-00 00:00:00', 0, 1, '', 0, '{"layout_type":"blog","show_category_title":"0","show_description":"","show_description_image":"","maxLevel":"","show_empty_categories":"","show_no_articles":"","show_subcat_desc":"","show_cat_num_articles":"","page_subheading":"","num_leading_articles":"4","num_intro_articles":"0","num_columns":"1","num_links":"2","multi_column_order":"1","show_subcategory_content":"","orderby_pri":"","orderby_sec":"rdate","order_date":"published","show_pagination":"2","show_pagination_results":"1","show_title":"","link_titles":"","show_intro":"","show_category":"0","link_category":"","show_parent_category":"","link_parent_category":"","info_bloc_position":"0","show_author":"","link_author":"","show_create_date":"","show_modify_date":"","show_publish_date":"0","show_item_navigation":"","show_vote":"","show_readmore":"","show_readmore_title":"","show_icons":"","show_print_icon":"","show_email_icon":"","show_hits":"0","show_noauth":"","show_feed_link":"1","feed_summary":"","menu-anchor_title":"","menu-anchor_css":"","menu_image":"","menu_text":1,"page_title":"","show_page_heading":0,"page_heading":"","pageclass_sfx":"","menu-meta_description":"","menu-meta_keywords":"","robots":"","secure":0}', 43, 44, 1, '*', 0),

Additional Information:

In fact, whether it is set as Two or Four, it does not help the new user. The reason being, in the Blog sample data there are only four articles for/in the category 'blog'. With the Number of Leading Articles (num_leading_articles) set to Four, the user will not even see the links.

The change has been suggested to reflect what is set in the option "# Links".

IMHO, it would be better to change the value of the option "# Leading Articles" to Two (from the present value of Four). This change would help the new users to see both the articles and the links. Of course, the sample data has to be changed to reflect the change.

IMHO, it would be better to change the value of the option "# Leading Articles" to Two (from the present value of Four). This change would help the new users to see both the articles and the links. Of course, the sample data has to be changed to reflect the change.

Agree.

I have tested this item ? unsuccessfully on c6f15b1

After installing Blog-Sample Data using applied Patch got "(…) the next two oldest articles. (…)".

But: As i can't uninstall PR #17929 i marke for sure this Test as unsuccessfully. Also Test Instructions (how to install Sample Data) are not up to date so maybe this PR needs updates.

Set to "closed" on behalf of @Quy by The JTracker Application at issues.joomla.org/joomla-cms/17926

Fixed in PR #19357