Feeling Lucky
?
[#17909] - [4.0] Clean up core editors
- Fixed in Code Base
- 9 Sep 2017
- Medium
- Build: 4.0-dev
- # 17909
- Diff
- dgt41:§4.0-dev-editors-clean-up
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
Remove the deprecated methods from Editors.
Remove the methods from src/Joomla/Editor (needs a deprecation in 3.9)
WHY?
- The code is largely deprecated since 3.7 (#12561)
- It's totally wrong to create executable javascript in PHP, PHP should just hand in some parameters and Javascript should execute according to these. Building executable code in PHP is wrong
Testing Instructions
Apply patch, edit an article, play with the xtd-buttons, add content, save. Everything should work.
Repeat the test for Editor none, and Codemirror
Everything should work for these 2 editors apart the closing modal which is a different bug in J4, PR is coming for that later on
Expected result
No inline, PHP created javascript!
Actual result
No inline, PHP created javascript but with the same behaviour and functionality as before
Documentation Changes Required
YES! We need to communicate this shortly with a post
joomla-cms-bot
- | Category | ⇒ | Libraries Front End Plugins |
| Status | New | ⇒ | Pending |
wilsonge
- | Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-09-09 15:09:43 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
brianteeman
- | Title |
|
||||||
dgt41
- comment
- 9 Sep 2017
wow, that was fast?