[#17907] - [fix] fixed PluginHelper import of xtd-editors plugins
- Fixed in Code Base
- 24 Jul 2018
- Medium
- Build: staging
- # 17907
- Diff
- julienV:fix-editors-xtd-plugins-import
- Pending hound Hound is busy reviewing changes... Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #17908 .
Summary of Changes
Modified PluginHelper import so that it can properly 'autocreate' editors-xtd type plugins.
The problem is that regular class name construction uses 'Plg' + Type + name, but it doesn't work here as those plugins actually use PlgButton or PlgEditorsXtd prefix. Of course, it would be best to rename the plugin type, but i guess it's not possible due to B/C.
Note that the same workaround is used in the Editor\Editor class
https://github.com/joomla/joomla-cms/blob/staging/libraries/src/Editor/Editor.php#L472
This changes allows to use com_ajax interface with editors-xtd plugins (for example to load a layout for the modal content), which is not possible at the moment.
Testing Instructions
Use provided loadtest plugin, which loads it's modal content using com_ajax
plg_xtd_editors_loadtest.zip
Expected result
Modal content should display 'Plugin was loaded' after clicking on the button
Actual result
It doesn't trigger the right function
Documentation Changes Required
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Status | New | ⇒ | Pending |
| Labels |
Added:
?
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17907.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17907.
mbabker
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-07-24 00:17:13 |
| Closed_By | ⇒ | mbabker | |
| Labels |
Added:
?
|
||
I have tested this item✅ successfully on 52d0020
Without PR
With PR
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17907.