Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#17904] - [4.0] [WIP] PHPUnit Upgrade to 6

? ? ? Pending

User tests: Successful: Unsuccessful:

avatar wilsonge
wilsonge
9 Sep 2017
  • Fixes the PHPUnit error with return typehints we currently have by upgrading us to PHPUnit 6
  • Fixes the mock builder
  • Uses the PHPUnit namespaced classes
  • Uses the mock builder consistently as getMock and getMockForAbstractClass are both removed
  • Removes friendsofphp/php-cs-fixer as it is not compatible with PHPUnit 6 (they argue about sebastian/diff)
  • Removes 3 application unit tests that weren't asserting anything

TODO

  • Agree approach on how to remove the now removed assertTag which is responsible for all 34 test fails. Options include
    • DomCrawler component
    • Regex
    • XML assertions and using html that is XML compliant
    • Deleting the tests and just not testing the HTML
  • Review 7 warnings from JAuthorisationTest
  • Ensure we're happy removing the 3 application unit tests - at the moment I guess they at least check there are no exceptions thrown......
avatar joomla-cms-bot joomla-cms-bot - change - 9 Sep 2017
Category ⇒ External Library Composer Change Libraries Unit Tests
avatar wilsonge wilsonge - open - 9 Sep 2017
avatar wilsonge wilsonge - change - 9 Sep 2017
Status New ⇒ Pending
avatar wilsonge wilsonge - change - 9 Sep 2017
Title
…
PHPUnit Upgrade to 6
[4.0] [WIP] PHPUnit Upgrade to 6
avatar wilsonge wilsonge - edited - 9 Sep 2017
avatar wilsonge wilsonge - change - 9 Sep 2017
The description was changed
avatar wilsonge wilsonge - edited - 9 Sep 2017
avatar wilsonge wilsonge - change - 9 Sep 2017
The description was changed
avatar wilsonge wilsonge - edited - 9 Sep 2017
avatar wilsonge wilsonge - change - 9 Sep 2017
Labels Added: ? ? ?
avatar wilsonge wilsonge - change - 9 Sep 2017
The description was changed
avatar wilsonge wilsonge - edited - 9 Sep 2017
avatar wilsonge wilsonge - change - 9 Sep 2017
The description was changed
avatar wilsonge wilsonge - edited - 9 Sep 2017
avatar keradus
keradus - comment - 6 Oct 2017

Removes friendsofphp/php-cs-fixer as it is not compatible with PHPUnit 6 (they argue about sebastian/diff)

@wilsonge instead, update PHP CS Fixer to ^2.7
I just saw that you are still using v1 here, 1.13 was release a year ago. if you need help with upgrade, let me know ;)

avatar wilsonge
wilsonge - comment - 26 Nov 2017

Closing in favour of PR #18870 - which makes this a lot simpler for now

avatar wilsonge wilsonge - change - 26 Nov 2017
Status Pending ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2017-11-26 19:12:53
Closed_By ⇒ wilsonge
avatar wilsonge wilsonge - close - 26 Nov 2017

Add a Comment

Login with GitHub to post a comment