[#17896] - Optimized PSR-4 namespace prefix search
- Fixed in Code Base
- 25 Nov 2017
- Medium
- Build: staging
- # 17896
- Diff
- ethernidee:staging
User tests: Successful: Unsuccessful:
Summary of Changes
Namespace prefix is now searched as "XXX\" instead of "XXX" in qualified class name. Previously, if prefix 'A' was registered, all namespaces, beginning with 'A' were tested, like "Apple\", "AI\", etc.
Votes
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Status | New | ⇒ | Pending |
| Easy | No | ⇒ | Yes |
| Easy | Yes | ⇒ | No |
| Labels |
Added:
?
|
||
I have tested this item
Tested on Win64, PHP 7.1.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17896.
| Status | Pending | ⇒ | Ready to Commit |
RTC after two successful tests.
@franz-wohlkoenig This can't be RTC because the second tester is the author of this PR.
| Status | Ready to Commit | ⇒ | Pending |
set Status back on Pending. Thanks for Hint @Quy
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17896.
Are the exception handler changes related to this pr? Please open a new pr with these changes. Thanks for understanding.
Sorry )) Ok, I will open new PR for refactored ExceptionHandler.
Done.
Could anyone else test the patch, so that it could be included in the next release?
@ethernidee if you test we have the secod needed Test.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17896.
@franz-wohlkoenig ethernidee created the patch, so he can't test it.
@ethernidee would be good if you can add a unit test for your changes, just to be sure we didn't break something. If you need help on that, let me know.
Used the patch successfully on working site.
Guys, the change is really primitive: http://www.php-fig.org/psr/psr-4/examples/
// project-specific namespace prefix
$prefix = 'Foo\\Bar\\';
In PSR-4 loader implementation example namespaces are registered with trailing backslash and thus are searched with backslash. So I added leading/trailing backslashes trimming to registerNamespace and append backspace to prefixes on search by force. That's all ) If you think, that this tiny change needs it's own unit test, ok.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17896.
Changes on the classloader can have big side effects. Personally I prefere to stay on the safe side.
| Category | Libraries | ⇒ | Libraries Unit Tests |
| Labels |
Added:
?
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17896.
Applied this loader.php on 4 real working sites. No troubles for a few weeks already. Automatical tests were also added. Can I mark the human test as successful or should we wait for another volunteer?
mbabker
- | Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-11-25 17:08:35 |
| Closed_By | ⇒ | mbabker |
I have tested this item✅ successfully on 4f44aa4
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17896.