Feeling Lucky
?
[#17894] - Fix wrong type cast breaking the updating of smart search indexer when a single token is given
- Fixed in Code Base
- 7 Sep 2017
- Medium
- Build: staging
- # 17894
- Diff
- ggppdk:patch-44
- Pending hound Hound is busy reviewing changes... Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #17880
The issue was introduced by PR #13511
@mbabker
@frankmayer (i am not mentioning you by mistake this is an intentional mention
(sorry for mentioning by mistake in the past))
Summary of Changes
Smart search indexer update method accepts
FinderIndexer::addTokensToDb()
Accepts
- either An array FinderIndexerToken objects
- or single FinderIndexerToken object
It has a type cast to force single FinderIndexerToken object to be an array of FinderIndexerToken objects
- but the typecast is wrong
and converts a single FinderIndexerToken object
to be an array
Testing Instructions
Code review
Also smart search indexer is updated properly
Expected result
Indexer can store single FinderIndexerToken object
Actual result
Indexer can not store single FinderIndexerToken object
Documentation Changes Required
None
joomla-cms-bot
- | Category | ⇒ | Administration com_finder |
| Status | New | ⇒ | Pending |
mbabker
- | Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-09-07 11:48:11 |
| Closed_By | ⇒ | mbabker | |
| Labels |
Added:
?
|
||
Sorry for the mess, guys and gals. I totally forgot that in this case the object itself would be cast into an array.
@ggppdk Thanks for finding and fixing this. As for the mentions, no issues, it happens ;)