? ? Pending

User tests: Successful: Unsuccessful:

avatar alikon
alikon
6 Sep 2017

Pull Request for partial Issue #17864 .

Summary of Changes

fix quote escape in sample_testing

Testing Instructions

install with sample_testing.sql

Expected result

no sql errors

Actual result

sql errors

avatar joomla-cms-bot joomla-cms-bot - change - 6 Sep 2017
Category Postgresql SQL Installation
avatar alikon alikon - open - 6 Sep 2017
avatar alikon alikon - change - 6 Sep 2017
Status New Pending
avatar wilsonge
wilsonge - comment - 7 Sep 2017

OK I don't get this one. Why is this suddenly changed from 3.x?

avatar alikon
alikon - comment - 8 Sep 2017

Looking at history of this file i've your same question

avatar csthomas
csthomas - comment - 8 Sep 2017

My fault from #14223
installation/sql/postgresql/sample_data.sql also requires a fix.

avatar alikon alikon - change - 8 Sep 2017
Labels Added: ?
avatar csthomas
csthomas - comment - 8 Sep 2017

Sample blog too, lines 86 and 88

avatar alikon
alikon - comment - 8 Sep 2017

i suspect didn't came out from #14223 https://github.com/csthomas/joomla-cms/blob/f8e8ee9528221856e1ba44795149e9311c06552f/installation/sql/mysql/sample_testing.sql#L360

'What''s New in 1.5?' seems correctly escaped at that time, still don't understand...

avatar alikon
alikon - comment - 8 Sep 2017

maybe a github "unicorn" ?

avatar csthomas
csthomas - comment - 8 Sep 2017

I have tested installation with sample_testing.sql before your patch with success. No errors.
PostgreSQL 9.5.8.

[UPDATED]
I did not understand this problem.

Now I test with psql to load sql files.

avatar csthomas csthomas - test_item - 8 Sep 2017 - Tested successfully
avatar csthomas
csthomas - comment - 8 Sep 2017

I have tested this item successfully on 4d22fdc


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17891.

avatar wilsonge wilsonge - change - 18 Sep 2017
Status Pending Ready to Commit
avatar wilsonge
wilsonge - comment - 18 Sep 2017

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17891.

avatar mbabker mbabker - close - 25 Sep 2017
avatar mbabker mbabker - merge - 25 Sep 2017
avatar mbabker mbabker - change - 25 Sep 2017
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-09-25 11:37:58
Closed_By mbabker
Labels Added: ?

Add a Comment

Login with GitHub to post a comment