? ? ? Pending

User tests: Successful: Unsuccessful:

avatar Hackwar
Hackwar
6 Sep 2017

We have a string for Year (JYEAR) in en-GB.ini, but not for month and day. This is just to make this consistent.

avatar joomla-cms-bot joomla-cms-bot - change - 6 Sep 2017
Category Language & Strings
avatar Hackwar Hackwar - open - 6 Sep 2017
avatar Hackwar Hackwar - change - 6 Sep 2017
Status New Pending
avatar infograf768
infograf768 - comment - 6 Sep 2017

And where do you use this?

avatar Hackwar
Hackwar - comment - 6 Sep 2017

I am using this in some code for a customer of mine for a birthday field.

avatar C-Lodder
C-Lodder - comment - 6 Sep 2017

If you're going to do this, you may aswell add all of them:

second(s), minute(s), hour(s), day(s), week(s), month(s), year(s)

Will be of great benefit for those who develop extensions that involve time

@brianteeman ?

avatar laoneo
laoneo - comment - 6 Sep 2017

It would probably also make sense to have them available on the back end too.

avatar brianteeman
brianteeman - comment - 6 Sep 2017

ask the team leader https://volunteers.joomla.org/teams/user-interface-text-working-group

It would seem logical to me that these strings exist in XX-xx.ini While we usually dont have strings that are not used you will see that we have all the month names etc

avatar infograf768
infograf768 - comment - 6 Sep 2017

why not inches, centimeters, litres, gallons, etc...
singular and plural while we are there...
i can think of dozains others.
imho, let 3pd, if they need them, add whatever they need in their extensions

avatar C-Lodder
C-Lodder - comment - 6 Sep 2017

@infograf768 - If that's you're thinking, then you may aswell close this PR

avatar mbabker
mbabker - comment - 6 Sep 2017

If the core language library is only providing strings for what core actually uses, is it really that good? We have a lot of date processing functions in core, to me it makes sense that we would have strings in core supporting those as practical.

I do find it funny though the line is being drawn on adding two common strings when we still ask new translation teams to translate keys removed from core 5 years ago though...

avatar brianteeman
brianteeman - comment - 6 Sep 2017

@Hackwar please just add the same strings to the ini file in the admin as well and then we can merge this - the two files are supposed ti be in sync with each other

avatar Bakual
Bakual - comment - 6 Sep 2017

I don't have an issue with adding Day and Month. But we certainly have to draw a line somewhere, so I wouldn't add second(s), minute(s), hour(s), day(s), week(s), month(s), year(s). I'd say that would go to far.
The core file aren't meant to be a general "commonly used words"-file. It's the "words commonly used in core"-file 😄

Anyway, for 3.8 it will be to late as language freeze is in effect. 3.8.1 would be earliest.

avatar brianteeman
brianteeman - comment - 6 Sep 2017

As these new keys are not being used anywhere then language freeze is irrelevant

avatar infograf768
infograf768 - comment - 6 Sep 2017

As these new keys are not being used anywhere then language freeze is irrelevant

Wrong. They are automatically added to crowdin and force TTs to review again that file.
We already have to let them know about the non-synced lib_joomla.ini. Enough for 3.8.0.

avatar Bakual
Bakual - comment - 6 Sep 2017

As these new keys are not being used anywhere then language freeze is irrelevant

They will be used in 3rd parties, that's the whole intention of this PR. 😄

avatar alikon
alikon - comment - 6 Sep 2017

we should re-think the whole process.... imho

avatar Bakual
Bakual - comment - 6 Sep 2017

@alikon You're not the first to say that, and some thoughts were already done 😄
For 4.0 that is something to consider, especially adding a "minimum version" tag to the language pack so newer packs can't be installed into "unsupported" outdated Joomla versions. But that also needs changes on the updateserver, and those changes have to wait till the packs are migrated to the new download site (at least I think so).

avatar alikon
alikon - comment - 6 Sep 2017

glad to know...
i hope in a next gsoc project we can leverage more on some dynamic/automated translation API

avatar infograf768
infograf768 - comment - 6 Sep 2017

@alikon
automated translation with correct results does not exist, even for largely spoken languages.
it is 5% correct for only parts of phrases and at 90% ridiculous. the 5% remaining have made big scores on twitter.😂

avatar joomla-cms-bot joomla-cms-bot - change - 7 Sep 2017
Category Language & Strings Administration Language & Strings
avatar Hackwar Hackwar - change - 7 Sep 2017
Labels Added: ? ?
avatar Hackwar
Hackwar - comment - 7 Sep 2017

I added the strings in the backend en-GB.ini. @brianteeman if those files should be at least somewhat in sync, then we failed pretty big there. Those files are everything but in sync....

avatar Bakual
Bakual - comment - 7 Sep 2017

en-GB.ini isn't supposed to be in sync. Only the en-GB.lib_joomla.ini one should be in sync.

avatar brianteeman brianteeman - test_item - 8 Sep 2017 - Tested successfully
avatar brianteeman
brianteeman - comment - 8 Sep 2017

I have tested this item ✅ successfully on 68f48d6


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17887.

avatar wilsonge wilsonge - test_item - 9 Sep 2017 - Tested successfully
avatar wilsonge wilsonge - change - 9 Sep 2017
Status Pending Ready to Commit
Labels
avatar wilsonge
wilsonge - comment - 9 Sep 2017

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17887.

avatar wilsonge
wilsonge - comment - 9 Sep 2017

I have tested this item ✅ successfully on 68f48d6


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17887.

avatar wilsonge
wilsonge - comment - 9 Sep 2017

I have tested this item ✅ successfully on 68f48d6


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17887.

avatar mbabker mbabker - change - 25 Sep 2017
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-09-25 11:38:40
Closed_By mbabker
Labels Added: ?
avatar mbabker mbabker - close - 25 Sep 2017
avatar mbabker mbabker - merge - 25 Sep 2017

Add a Comment

Login with GitHub to post a comment