[#17859] - [com_fields] Update fields.php
- Fixed in Code Base
- 14 Apr 2020
- Medium
- Build: staging
- # 17859
- Diff
- farzadtaheri:patch-1
- Success Hound No violations found. Woof! Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success continuous-integration/drone/pr the build was successful Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
User tests: Successful: Unsuccessful:
Problem: com_fields category fields change event causing problem in Persian fa-IR.
with this change, all calendars fields with localized data type (like Jalali) are converted to standard date type and then submit form.
Pull Request for Issue #16628 .
Summary of Changes
replace line 333 and change this code:
element.form.submit();
to
Joomla.submitform('" . $section . ".reload', element.form);
Testing Instructions
1- make sure you have more than two category for articles(com_content)
2- make sure you have at least a field for articles with context: com_content.article in com_fields
3- change back-end language to Persian(fa-IR).
4- go to Content > Articles. in Persian language the path is: محتوا > مطالب
5- edit an article and change category field value to another one.
Expected result
before this change:
after change category field value all calendar fields value change to empty.
after change code and replace line 333 with new one:
don`t show any error and fully reload page after ajax call and old calendar field values are show correctly.
joomla-cms-bot
- | Category | ⇒ | Administration com_fields |
| Status | New | ⇒ | Pending |
@infograf768 it seems reasonable but I cannot test it at the moment
I think you need to make sure that the core js file is loaded.
franz-wohlkoenig
- | Title |
|
||||||
| Title |
|
||||||
This was urgent in 2017 - has it been fixed elsewhere?
| Labels |
Added:
?
|
||
@brianteeman, unfortunately not yet!
Is this PR still to test?
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17859.
Do I have to do anything?
@farzadtaheri See your previous comment. #17859 (comment)
@brianteeman, unfortunately not yet!
@farzadtaheri See your previous comment. #17859 (comment)
@Quy @brianteeman
I just started with Github and my original language is not English
So I may be misunderstood
I wrote the PR, which I tested it by myself and it works perfectly and solves the issue.
Do I need to do anything else to merage this PR? please Guide Me.
I'v posted it in the public testing glip group. Maybe we will get some testers.
Change looks fine for me.
@laoneo I've just tested this PR, but not really successful regarding the described issue.
Regardless if the PR is applied or not, and regardless is the backend language is Persian or English (GB), the published date changes when changing category of an article if the website time zone in Global Configuration is set to something else than UTC, and it doesn't change when the website time zone is UTC (without a time zone for the user set in all these cases).
This seems to be solved by PR #28596 instead (have to test that again with Persian backend language).
But this PR here seems to fix another issue: When the backend language is Persian and the PR is not applied and I change the category of an article, the toolbar and top menu bar disappear with the page reaload.
When the PR is applied this doesn't happen. When backend language is English (GB), this also doesn't happen.
Can someone check and replicate my findings?
Can someone check and replicate my findings?
I confirm.
The errror is
It is solved by this PR.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17859.
I have tested this item
See my and @infograf768 's previous comments about details.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17859.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17859.
@HLeithner
Let's merge this one please for 3.9.17
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-04-14 14:56:40 |
| Closed_By | ⇒ | HLeithner | |
| Labels |
Added:
?
|
||
Thanks
@dgt41
Please check this urgently as RC is tomorrow