[#17851] - First batch of module tmpl codestyle
- Closed
- 13 Jan 2018
- Medium
- Build: staging
- # 17851
- Diff
- zero-24:modules#1
User tests: Successful: Unsuccessful:
Summary of Changes
First batch of module tmpl codestyle
Testing Instructions
Please test and review the following frontend modules using the testing sampledata
- mod_articles_archive
- mod_articles_categories
- mod_articles_category
- mod_articles_latest
- mod_articles_news
- mod_articles_popular
- mod_banners
- mod_breadcrumbs
- mod_custom
Expected result
Still works
Actual result
Works with codestyle problems
Documentation Changes Required
none
joomla-cms-bot
- | Category | ⇒ | Modules Front End |
| Status | New | ⇒ | Pending |
you're killing us, do it in J4...
It'd actually be better if the code style were consistent across branches. If you're making massive code style changes in only one branch you're making even more merge conflict issues as time goes on.
It'd actually be better if the code style were consistent across branches. If you're making massive code style changes in only one branch you're making even more merge conflict issues as time goes on.
So what is your suggestion? Doing it against staging or 4.0?
Keep going against staging. In theory there should only be one merge that has major conflicts, every merge after that should only deal with lines changed between the two branches.
| Labels |
Added:
?
|
||
I have tested this item
Code review
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17851.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-01-13 12:52:15 |
| Closed_By | ⇒ | zero-24 |
@zero-24 you're killing us, do it in J4...