User tests: Successful: Unsuccessful:
Pull Request for Issue #17820 .
When the user wants to update to a new Joomla version but has a PHP version installed or uses a database type (sqlsrv or sqlazure when updating to Joomla 4.0) that is not supported by the new version, new error messages are shown to the user. Previously, in all of these cases, the notice "We can't find a download URL" was shown. This hint is now only shown, when the user has a compatible php version installed and uses a compatible DB type. Therefore, the JUpdate class now always returns the minimum php version, even when the currently installed php version is not compatible.
list.xml
at /
<extensionset>
<extension element="joomla" type="file" version="4.0.0" targetplatformversion="3.9" detailsurl="http://localhost/extension_sts.xml" />
</extensionset>
extension_sts.xml
at /
<updates>
<update>
<name>Joomla! 3.7</name>
<description>Joomla! 3.7 CMS</description>
<element>joomla</element>
<type>file</type>
<version>4.0.0</version>
<infourl title="Joomla!">https://www.joomla.org/announcements/release-news/5711-joomla-3-7-5-release.html</infourl>
<downloads>
<downloadurl type="full" format="zip">https://downloads.joomla.org/cms/joomla3/3-7-5/Joomla_3.7.5-Stable-Update_Package.zip</downloadurl>
</downloads>
<tags>
<tag>stable</tag>
</tags>
<maintainer>Joomla! PLT</maintainer>
<maintainerurl>https://www.joomla.org</maintainerurl>
<section>STS</section>
<targetplatform name="joomla" version="3.[23456789]" />
<php_minimum>7.0</php_minimum>
</update>
</updates>
Custom URL: localhost/list.xml
There should be a fake update to Joomla 4.0 and you should see the pre update checker from #17742
When changing the version in <php_minimum>-tag to 8 in the file extension_sts.xml
at /
you should see a hint that your current php version is not supported.
Add your current database type (e.g. mysqli
) to $unsupportedDatabaseTypes
in function isDatabaseTypeSupported()
in file ./administrator/components/com_joomlaupdate/models/default.php
.
You should now see two error descriptions, one for the not supported php version and one for the used db type being not compatible.
You see different error descriptions depending on the error preventing the update to be installed. (Wrong PHP Version, wrong DB type, problem with update server).
You only see one error description, no matter if the download fails due to a problem with the Joomla Update Server or due to your server not meeting the minimum update requirements.
None.
Category | ⇒ | Administration com_joomlaupdate Language & Strings Libraries |
Status | New | ⇒ | Pending |
Labels |
Added:
?
?
|
I have tested this item
@icampus
I could reproduce the Bug by following the testing Instructions. The item fixed the Bug. Everything works fine.
Status | Pending | ⇒ | Ready to Commit |
RTC after two successful tests.
I have tested this item
@icampus
I followed the test instruction and it was successfully
Looks good - thanks
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-09-04 23:24:16 |
Closed_By | ⇒ | wilsonge | |
Labels |
Added:
?
|
I have tested this item✅ successfully on 75e0575
Tested 3 cases: unsupported php version, unsupported database type, both.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17849.