? ? ? Pending

User tests: Successful: Unsuccessful:

avatar Kev1n337
Kev1n337
3 Sep 2017

Pull Request for Issue #17820 .

Summary of Changes

When the user wants to update to a new Joomla version but has a PHP version installed or uses a database type (sqlsrv or sqlazure when updating to Joomla 4.0) that is not supported by the new version, new error messages are shown to the user. Previously, in all of these cases, the notice "We can't find a download URL" was shown. This hint is now only shown, when the user has a compatible php version installed and uses a compatible DB type. Therefore, the JUpdate class now always returns the minimum php version, even when the currently installed php version is not compatible.

Testing Instructions

  1. Create file list.xml at /
<extensionset>
    <extension element="joomla" type="file" version="4.0.0" targetplatformversion="3.9" detailsurl="http://localhost/extension_sts.xml" />
</extensionset>
  1. Create file extension_sts.xml at /
<updates>
    <update>
        <name>Joomla! 3.7</name>
        <description>Joomla! 3.7 CMS</description>
        <element>joomla</element>
        <type>file</type>
        <version>4.0.0</version>
        <infourl title="Joomla!">https://www.joomla.org/announcements/release-news/5711-joomla-3-7-5-release.html</infourl>
        <downloads>
            <downloadurl type="full" format="zip">https://downloads.joomla.org/cms/joomla3/3-7-5/Joomla_3.7.5-Stable-Update_Package.zip</downloadurl>
        </downloads>
        <tags>
            <tag>stable</tag>
        </tags>
        <maintainer>Joomla! PLT</maintainer>
        <maintainerurl>https://www.joomla.org</maintainerurl>
        <section>STS</section>
        <targetplatform name="joomla" version="3.[23456789]" />
        <php_minimum>7.0</php_minimum>
    </update>
</updates>
  1. Components -> Joomla! Update -> Options

Custom URL: localhost/list.xml

  1. Save & Close

There should be a fake update to Joomla 4.0 and you should see the pre update checker from #17742

  1. When changing the version in <php_minimum>-tag to 8 in the file extension_sts.xml at / you should see a hint that your current php version is not supported.

  2. Add your current database type (e.g. mysqli) to $unsupportedDatabaseTypes in function isDatabaseTypeSupported() in file ./administrator/components/com_joomlaupdate/models/default.php.

  3. You should now see two error descriptions, one for the not supported php version and one for the used db type being not compatible.

updateerrors

Expected result

You see different error descriptions depending on the error preventing the update to be installed. (Wrong PHP Version, wrong DB type, problem with update server).

Actual result

You only see one error description, no matter if the download fails due to a problem with the Joomla Update Server or due to your server not meeting the minimum update requirements.

Documentation Changes Required

None.

avatar joomla-cms-bot joomla-cms-bot - change - 3 Sep 2017
Category Administration com_joomlaupdate Language & Strings Libraries
avatar Kev1n337 Kev1n337 - open - 3 Sep 2017
avatar Kev1n337 Kev1n337 - change - 3 Sep 2017
Status New Pending
avatar Kev1n337 Kev1n337 - change - 3 Sep 2017
The description was changed
avatar Kev1n337 Kev1n337 - edited - 3 Sep 2017
avatar Kev1n337 Kev1n337 - change - 3 Sep 2017
The description was changed
avatar Kev1n337 Kev1n337 - edited - 3 Sep 2017
avatar SamuelSchepp SamuelSchepp - test_item - 3 Sep 2017 - Tested successfully
avatar SamuelSchepp
SamuelSchepp - comment - 3 Sep 2017

I have tested this item successfully on 75e0575

Tested 3 cases: unsupported php version, unsupported database type, both.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17849.

avatar Kev1n337 Kev1n337 - change - 4 Sep 2017
Labels Added: ? ?
avatar Schmidie64 Schmidie64 - test_item - 4 Sep 2017 - Tested successfully
avatar Schmidie64
Schmidie64 - comment - 4 Sep 2017

I have tested this item successfully on ff7abaa

@icampus
I could reproduce the Bug by following the testing Instructions. The item fixed the Bug. Everything works fine.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17849.

avatar franz-wohlkoenig franz-wohlkoenig - change - 4 Sep 2017
Status Pending Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 4 Sep 2017

RTC after two successful tests.

avatar Dennissehrt Dennissehrt - test_item - 4 Sep 2017 - Tested successfully
avatar Dennissehrt
Dennissehrt - comment - 4 Sep 2017

I have tested this item successfully on ff7abaa


@icampus
I followed the test instruction and it was successfully


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17849.

avatar brianteeman
brianteeman - comment - 4 Sep 2017

Looks good - thanks

avatar wilsonge wilsonge - change - 4 Sep 2017
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-09-04 23:24:16
Closed_By wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 4 Sep 2017
avatar wilsonge wilsonge - merge - 4 Sep 2017

Add a Comment

Login with GitHub to post a comment