User tests: Successful: Unsuccessful:
Pull Request for Issue #17188 & related to PR #17838
Right now the linked modules in the menus view of com_menus are checked for the edit permission for the menu, instead of the linked module. This PR checks if the user can edit the linked module, if not the link will be disabled, as it is common in Joomla to disable links instead of hiding them.
Module Test
Special
Module Test
user group in the Global Configuration permissionsAccess Administration Interface
and Edit
action for both Menu & Module component permissions for the Module Test
user group.Main Menu
. Set Edit
action permission to denied for the Module Test
user groupModule Test
user groupRight now you can click on the linked modules, even when you do not have permissions. With #17838 an error message will be visible (without that PR you can edit the module, which is an ACL violation).
Apply the patch, and not the linked menu module without edit access is disabled and you can't click on it to edit the module anymore.
Category | ⇒ | Administration com_menus |
Status | New | ⇒ | Pending |
I have tested this item
Status | Pending | ⇒ | Ready to Commit |
RTC after two successful tests.
Labels |
Added:
?
|
Labels |
Added:
?
|
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-09-03 16:34:48 |
Closed_By | ⇒ | mbabker |
I have tested this item✅ successfully on c6d1419
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17845.