? ? Pending

User tests: Successful: Unsuccessful:

avatar sanderpotjer
sanderpotjer
3 Sep 2017

Pull Request for Issue #17188 & related to PR #17838

Summary of Changes

Right now the linked modules in the menus view of com_menus are checked for the edit permission for the menu, instead of the linked module. This PR checks if the user can edit the linked module, if not the link will be disabled, as it is common in Joomla to disable links instead of hiding them.

Testing Instructions

  • Create a new user group Module Test
  • Assign this user group to access level Special
  • Allow the backend login action for the Module Test user group in the Global Configuration permissions
  • Allow Access Administration Interface and Edit action for both Menu & Module component permissions for the Module Test user group.
  • Open the module that displays one of your menu's, eg the Main Menu. Set Edit action permission to denied for the Module Test user group
  • Create a test user, assign to Module Test user group
  • Login with test user
  • Go to Menus -> Manage

Actual result

Right now you can click on the linked modules, even when you do not have permissions. With #17838 an error message will be visible (without that PR you can edit the module, which is an ACL violation).

Expected result

Apply the patch, and not the linked menu module without edit access is disabled and you can't click on it to edit the module anymore.

In this example the sitemap menu module is disabled:
screen shot 2017-09-03 at 11 41 24

avatar joomla-cms-bot joomla-cms-bot - change - 3 Sep 2017
Category Administration com_menus
avatar sanderpotjer sanderpotjer - open - 3 Sep 2017
avatar sanderpotjer sanderpotjer - change - 3 Sep 2017
Status New Pending
avatar brianteeman brianteeman - test_item - 3 Sep 2017 - Tested successfully
avatar brianteeman
brianteeman - comment - 3 Sep 2017

I have tested this item successfully on c6d1419


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17845.

avatar franz-wohlkoenig franz-wohlkoenig - test_item - 3 Sep 2017 - Tested successfully
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 3 Sep 2017

I have tested this item successfully on c6d1419


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17845.

avatar franz-wohlkoenig franz-wohlkoenig - change - 3 Sep 2017
Status Pending Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 3 Sep 2017

RTC after two successful tests.

avatar sanderpotjer sanderpotjer - change - 3 Sep 2017
Labels Added: ?
avatar sanderpotjer sanderpotjer - change - 3 Sep 2017
Labels Added: ?
avatar mbabker mbabker - change - 3 Sep 2017
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-09-03 16:34:48
Closed_By mbabker
avatar mbabker mbabker - close - 3 Sep 2017
avatar mbabker mbabker - merge - 3 Sep 2017

Add a Comment

Login with GitHub to post a comment