?

Steps to reproduce the issue

All frontend:

  1. Login on one device with activated "remember-me" checkbox and close the browser again.
  2. Login on another device and change your password here.
  3. Go back to your first device and open the website again.

Expected result

As the password is changed now, the "silent" login should not successfully proceed.

Actual result

You are logged into the website on your first device (actually assuming the old password is still working), even though the password was changed since you first logged in.

System information (as much as possible)

Joomla CMS all versions

Additional comments

This is a security risk for the user: If someone (an ex boyfriend) can access a device where the user previously was logged in (with remember-me functionality activated), changing the users password cannot keep this person out of the users account.
(I am afraid this is not a hypthetical risk - www.alicerugglestrust.org )

I do have a patched "system-remember" plugin ready and I like to submit this to the core, but am un-knowledgeable with the "pull-request" procedure.

avatar schultz-it-solutions schultz-it-solutions - open - 1 Sep 2017
avatar joomla-cms-bot joomla-cms-bot - change - 1 Sep 2017
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 1 Sep 2017
avatar schultz-it-solutions
schultz-it-solutions - comment - 1 Sep 2017

I could attach those changed files here if you like...

avatar franz-wohlkoenig franz-wohlkoenig - change - 1 Sep 2017
Category com_plugins
avatar franz-wohlkoenig franz-wohlkoenig - change - 1 Sep 2017
Status New Discussion
avatar Bakual
Bakual - comment - 1 Sep 2017

The remember-me doesn't use any password at all. That's why it will still work when you changed the password.

avatar mbabker
mbabker - comment - 1 Sep 2017

The issue is if you reset your account credentials, it should invalidate that remember me cookie. Just yesterday I reset my password on a website and my remember me authentication on all devices for that site was invalidated, I had to re-login (and authorize remember me again) for the new credentials.

avatar schultz-it-solutions
schultz-it-solutions - comment - 1 Sep 2017

I know, but if we delete the corresponding #__user_keys, these cookies remain useless.
that is what I did here:
9c09cc1

avatar brianteeman
brianteeman - comment - 1 Sep 2017

closing here as we know have a pull request and should continue any discussion there.

avatar brianteeman brianteeman - change - 1 Sep 2017
Status Discussion Closed
Closed_Date 0000-00-00 00:00:00 2017-09-01 13:48:25
Closed_By brianteeman
avatar brianteeman brianteeman - close - 1 Sep 2017

Add a Comment

Login with GitHub to post a comment