? ? Pending

User tests: Successful: Unsuccessful:

avatar mbabker
mbabker
1 Sep 2017

Summary of Changes

Upgraded sodium_compat polyfill which fixes the issues with the polyfill on a 32-bit PHP build.

Testing Instructions

No easy direct test so either use the API as documented in the tests or validate the tests pass.

avatar joomla-cms-bot joomla-cms-bot - change - 1 Sep 2017
Category External Library Composer Change Libraries Repository
avatar mbabker mbabker - open - 1 Sep 2017
avatar mbabker mbabker - change - 1 Sep 2017
Status New Pending
avatar wilsonge
wilsonge - comment - 1 Sep 2017

Changes to the autoload_classmap.php seem slightly suspect?

avatar mbabker
mbabker - comment - 1 Sep 2017

I have a feeling someone else has been manually removing those. Because if you look at the composer.json for all packages at the versions we have they are not in the autoload-dev section.

avatar wilsonge
wilsonge - comment - 1 Sep 2017

Hmm looks like it was something to do with the optimizer??? mbabker/joomla-cms@1fba80f

avatar mbabker
mbabker - comment - 1 Sep 2017

It has nothing to do with the optimizer. I literally ran composer install, composer update paragonie/random_compat, composer install --no-dev.

The test classes have been in the namespace mapping for a while. See https://github.com/joomla/joomla-cms/blob/3.7.5/libraries/vendor/composer/autoload_psr4.php

The fact that the test classes are being re-added to the class mapping files with this PR to me indicates manual removal at another point or someone is running a really goofy Composer command/configuration.

avatar wilsonge wilsonge - change - 1 Sep 2017
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-09-01 12:06:37
Closed_By wilsonge
Labels Added: ? ?
avatar wilsonge wilsonge - close - 1 Sep 2017
avatar wilsonge wilsonge - merge - 1 Sep 2017

Add a Comment

Login with GitHub to post a comment