? Pending

User tests: Successful: Unsuccessful:

avatar N6REJ
N6REJ
30 Aug 2017

Pull Request for Issue # .

Summary of Changes

Code Style requires no spaces between & $item

Testing Instructions

code review

Expected result

Actual result

Documentation Changes Required

avatar joomla-cms-bot joomla-cms-bot - change - 30 Aug 2017
Category Repository Front End com_contact com_content
avatar N6REJ N6REJ - open - 30 Aug 2017
avatar N6REJ N6REJ - change - 30 Aug 2017
Status New Pending
avatar brianteeman
brianteeman - comment - 30 Aug 2017

@N6REJ the .gitignore file should not be part of the pr

avatar N6REJ N6REJ - change - 30 Aug 2017
Labels Added: ?
avatar N6REJ
N6REJ - comment - 30 Aug 2017

I THINK I fixed it, I noticed that it added it after I created the PR , sorry.

avatar brianteeman
brianteeman - comment - 30 Aug 2017

no you managed to delete the file completely - oops

avatar N6REJ N6REJ - change - 30 Aug 2017
The description was changed
avatar N6REJ N6REJ - edited - 30 Aug 2017
avatar N6REJ
N6REJ - comment - 30 Aug 2017

ok, so, how do I fix it?

avatar N6REJ
N6REJ - comment - 30 Aug 2017

just fyi, I just created another branch {codestyle2} and redid the fix and on commit it only committed the 3 changed files but then when I do a pr it looks like its trying to delete/add .gitignore again :(

avatar C-Lodder
C-Lodder - comment - 30 Aug 2017

Submitted a PR to your branch: N6REJ#3

avatar N6REJ
N6REJ - comment - 30 Aug 2017

@C-Lodder ty! Done ?‍♂️

avatar joomla-cms-bot joomla-cms-bot - change - 30 Aug 2017
Category Repository Front End com_contact com_content Front End com_contact com_content
avatar N6REJ
N6REJ - comment - 30 Aug 2017

@dgt41 @C-Lodder ty guys.

avatar zero-24 zero-24 - change - 30 Aug 2017
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-08-30 20:44:40
Closed_By zero-24
avatar zero-24 zero-24 - close - 30 Aug 2017
avatar zero-24 zero-24 - merge - 30 Aug 2017
avatar zero-24
zero-24 - comment - 30 Aug 2017

merging thanks.

avatar N6REJ
N6REJ - comment - 30 Aug 2017

do I delete my branch now or wait?

avatar C-Lodder
C-Lodder - comment - 30 Aug 2017

@N6REJ yes, you can delete it

avatar brianteeman
brianteeman - comment - 30 Aug 2017

@N6REJ congratulations on the pr. Sorry I went quiet I was speaking at a user grohp

avatar N6REJ
N6REJ - comment - 31 Aug 2017

@C-Lodder how the heck did you fix the dang .gitignore issue? It's doing it again on another pr I want to make shoots self with shotgun spelling
I even went as far as to delete the repo, local and refork! / reclone
When I go to do the committ it does show its trying to put .gitignore there ( which is stupid ) but it is lined out cause I've unchecked it..
image

avatar wojsmol
wojsmol - comment - 31 Aug 2017

@N6REJ The problem with .gitignore is that netbeans adds to it /nbproject/private/ - see https://docs.joomla.org/NetBeans_overview Creating a project and debugging point 3.3 for a solution.

avatar C-Lodder
C-Lodder - comment - 31 Aug 2017

Because you probably created a fork of a branch where you had already removed the file.

When PRs get merged, you need to make sure you update your repo. You can use command line or the Github UI. Or if you raraly contribue PRs, delete your fork and re-fork it completely.

Add a Comment

Login with GitHub to post a comment