User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Code Style requires no spaces between & $item
code review
Category | ⇒ | Repository Front End com_contact com_content |
Status | New | ⇒ | Pending |
Labels |
Added:
?
|
I THINK I fixed it, I noticed that it added it after I created the PR , sorry.
no you managed to delete the file completely - oops
ok, so, how do I fix it?
just fyi, I just created another branch {codestyle2} and redid the fix and on commit it only committed the 3 changed files but then when I do a pr it looks like its trying to delete/add .gitignore again :(
Category | Repository Front End com_contact com_content | ⇒ | Front End com_contact com_content |
Status | Pending | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-08-30 20:44:40 |
Closed_By | ⇒ | zero-24 |
merging thanks.
do I delete my branch now or wait?
@C-Lodder how the heck did you fix the dang .gitignore issue? It's doing it again on another pr I want to make shoots self with shotgun spelling
I even went as far as to delete the repo, local and refork! / reclone
When I go to do the committ it does show its trying to put .gitignore there ( which is stupid ) but it is lined out cause I've unchecked it..
@N6REJ The problem with .gitignore is that netbeans adds to it /nbproject/private/
- see https://docs.joomla.org/NetBeans_overview Creating a project and debugging
point 3.3 for a solution.
Because you probably created a fork of a branch where you had already removed the file.
When PRs get merged, you need to make sure you update your repo. You can use command line or the Github UI. Or if you raraly contribue PRs, delete your fork and re-fork it completely.
@N6REJ the .gitignore file should not be part of the pr