?
avatar C-Lodder
C-Lodder
30 Aug 2017

This PR #10011 introduces an item-featured class which doesn't actually get used in core.

Absolutely no point in adding a class to the DOM just incase someone applies some CSS to it. They can create a template override.

avatar C-Lodder C-Lodder - open - 30 Aug 2017
avatar joomla-cms-bot joomla-cms-bot - change - 30 Aug 2017
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 30 Aug 2017
avatar C-Lodder C-Lodder - change - 30 Aug 2017
The description was changed
avatar C-Lodder C-Lodder - edited - 30 Aug 2017
avatar brianteeman
brianteeman - comment - 30 Aug 2017

it is really silly to merge something in j3 only to remove it in j4

if you feel so strongly about this (my opinion is on that thread) then you should (continue to) express it there

avatar franz-wohlkoenig franz-wohlkoenig - change - 30 Aug 2017
Category com_contact com_content com_modules
avatar franz-wohlkoenig franz-wohlkoenig - change - 30 Aug 2017
Status New Discussion
avatar Bakual
Bakual - comment - 30 Aug 2017

I'm confused, since @C-Lodder seem to have supported it in #10011 (comment) and now wants to revert it before it even got merged. That just doesn't make sense to me.

avatar C-Lodder
C-Lodder - comment - 30 Aug 2017

Bakual, didnt even remember doing that so probably wasnt in the 'right frame of mind'.

Will close this and post on there then

avatar C-Lodder C-Lodder - change - 30 Aug 2017
Status Discussion Closed
Closed_Date 0000-00-00 00:00:00 2017-08-30 15:42:31
Closed_By C-Lodder
avatar C-Lodder C-Lodder - close - 30 Aug 2017

Add a Comment

Login with GitHub to post a comment