? Pending

User tests: Successful: Unsuccessful:

avatar wilsonge
wilsonge
30 Aug 2017

As part of the new routing we have added an Exception thrown in the Router when a route is invalid. There are now multiple ways of giving 404 issues and it's all getting a bit crazy, with us adding webservices into 4.0 this is becoming a bit of a problem, so I'm adding a parent exception that all 404 issues should extend from (I'm choosing to add it into 3.8 so that we're using it from day 1 rather than waiting for 4). The new exception in 3.8 will use this as well as the MissingComponentException (note this is b/c because RouteNotFoundException also extends InvalidArgumentException which means instanceof checks will still work).

Testing

By definition nothing here should change there's now just a single parent exception to cover them all. So you can test that all 404 exceptions continue to be thrown as before.

avatar joomla-cms-bot joomla-cms-bot - change - 30 Aug 2017
Category Libraries
avatar wilsonge wilsonge - open - 30 Aug 2017
avatar wilsonge wilsonge - change - 30 Aug 2017
Status New Pending
avatar wilsonge wilsonge - change - 30 Aug 2017
The description was changed
avatar wilsonge wilsonge - edited - 30 Aug 2017
avatar mbabker mbabker - change - 30 Aug 2017
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-08-30 11:54:58
Closed_By mbabker
Labels Added: ?
avatar mbabker mbabker - close - 30 Aug 2017
avatar mbabker mbabker - merge - 30 Aug 2017

Add a Comment

Login with GitHub to post a comment