? ? Success

User tests: Successful: Unsuccessful:

avatar jalilyacob
jalilyacob
30 Aug 2017

Pull Request for Issue # .

Summary of Changes

JDatabaseQuery: Add support to multiple-table deletion with Join of the delete() function.

Testing Instructions

$query->delete('a, b')->from('#__a AS a')->leftJoin('#__b AS b ON a.id = b.id')->where('a.id = 1');

Expected result

DELETE a, b FROM #__a AS a LEFT JOIN #__b AS b ON a.id = b.id WHERE a.id = 1;

Actual result

DELETE a, b FROM #__a AS a LEFT JOIN #__b AS b ON a.id = b.id WHERE a.id = 1;

Documentation Changes Required

Added the following usage instruction:
Other Usage (Added to support multiple-delete using join):
$query->delete('a, b')->from('#__a AS a')->leftJoin('#__b AS b ON a.id = b.id')->where('a.id = 1');

Output Query:
DELETE a, b FROM #__a AS a LEFT JOIN #__b AS b ON a.id = b.id WHERE a.id = 1;

avatar joomla-cms-bot joomla-cms-bot - change - 30 Aug 2017
Category Administration com_admin com_categories com_contact com_content com_finder com_menus com_modules com_newsfeeds Language & Strings Modules Front End com_search
avatar jalilyacob jalilyacob - open - 30 Aug 2017
avatar jalilyacob jalilyacob - change - 30 Aug 2017
Status New Pending
avatar jalilyacob jalilyacob - change - 30 Aug 2017
The description was changed
avatar jalilyacob jalilyacob - edited - 30 Aug 2017
avatar jalilyacob jalilyacob - change - 30 Aug 2017
The description was changed
avatar jalilyacob jalilyacob - edited - 30 Aug 2017
avatar jalilyacob jalilyacob - change - 30 Aug 2017
The description was changed
avatar jalilyacob jalilyacob - edited - 30 Aug 2017
avatar laoneo
laoneo - comment - 30 Aug 2017

I guess you messed up your branch. Also please give the pull request a proper title.

avatar brianteeman
brianteeman - comment - 30 Aug 2017

I am closing this at this time. Please resubmit your pr to the staging branch

avatar brianteeman brianteeman - change - 30 Aug 2017
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2017-08-30 08:05:40
Closed_By brianteeman
Labels Added: ? ?
avatar brianteeman brianteeman - close - 30 Aug 2017

Add a Comment

Login with GitHub to post a comment