Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#17764] - New contact css issue

? Pending

User tests: Successful: Unsuccessful:

avatar lavipr
lavipr
29 Aug 2017

Pull Request for Issue #15271 .

Summary of Changes

Prevent to overlapping content of the columns, when there are three columns. This depends of the width of the popup, where the issue appeared before.

Testing Instructions

in backend:
Menus > Main Menu > Add Menu Item > Menu Item Type: Contacts > Single Contact -> Select Contact: > Create (New Contact) - button

Expected result

No overlapping anymore.
nooverlapping

Actual result

Overlapping between window.innerWidth 1225px and 1515px
overlapping

Site Information

siteinfo

Documentation Changes Required

No

developed @icampus

avatar joomla-cms-bot joomla-cms-bot - change - 29 Aug 2017
Category ⇒ Administration Templates (admin) JavaScript Front End Templates (site)
avatar lavipr lavipr - open - 29 Aug 2017
avatar lavipr lavipr - change - 29 Aug 2017
Status New ⇒ Pending
avatar lavipr lavipr - change - 29 Aug 2017
The description was changed
avatar lavipr lavipr - edited - 29 Aug 2017
avatar brianteeman brianteeman - test_item - 30 Aug 2017 - Tested successfully
avatar brianteeman
brianteeman - comment - 30 Aug 2017

I have tested this item ✅ successfully on 44d1e54

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17764.

avatar franz-wohlkoenig franz-wohlkoenig - test_item - 30 Aug 2017 - Tested successfully
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 30 Aug 2017

I have tested this item ✅ successfully on 44d1e54

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17764.

avatar franz-wohlkoenig franz-wohlkoenig - change - 30 Aug 2017
Status Pending ⇒ Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 30 Aug 2017

RTC after two successful tests.

avatar C-Lodder
C-Lodder - comment - 30 Aug 2017

This is a very dirty approach.

I would strongly suggest:

  • Removing all your Javascript
  • Adding a class to one of the parent elements in the HTML markup
  • Use CSS media queries to change the styling
avatar joomla-cms-bot joomla-cms-bot - change - 30 Aug 2017
Category Administration Templates (admin) JavaScript Front End Templates (site) ⇒ Administration com_contact Templates (admin) Front End Templates (site)
avatar lavipr lavipr - change - 30 Aug 2017
Labels Added: ?
avatar lavipr
lavipr - comment - 30 Aug 2017

PR updated

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17764.

avatar mbabker
mbabker - comment - 31 Aug 2017

Needs a test other than the review after the changes were made.

avatar franz-wohlkoenig franz-wohlkoenig - test_item - 31 Aug 2017 - Tested successfully
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 31 Aug 2017

I have tested this item ✅ successfully on dc079e8

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17764.

avatar sanderpotjer sanderpotjer - test_item - 31 Aug 2017 - Tested successfully
avatar sanderpotjer
sanderpotjer - comment - 31 Aug 2017

I have tested this item ✅ successfully on dc079e8

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17764.

avatar mbabker mbabker - change - 1 Sep 2017
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2017-09-01 12:18:47
Closed_By ⇒ mbabker
avatar mbabker mbabker - close - 1 Sep 2017
avatar mbabker mbabker - merge - 1 Sep 2017

Add a Comment

Login with GitHub to post a comment