? Pending

User tests: Successful: Unsuccessful:

avatar Bakual
Bakual
29 Aug 2017

Apparently, the CSS block which is supposed to target IE8, also affects IE11 and breaks it.

Summary of Changes

Removes the code unless someone knows a better way to fix it.
Pretty sure IE11 is currently used more than IE8 thus I'd go with breaking the smaller percentage of users ?
Code was added with #3474

Please note I wasn't able to test with IE8. The PR also fixed various issues which probably aren't tied to that CSS rules. So I'm not sure what exactly will break in IE8.

Testing Instructions

use Searchtools (eg in Articles Manager)

Expected result

ie11fixed

Actual result

ie11

Documentation Changes Required

None

avatar Bakual Bakual - open - 29 Aug 2017
avatar Bakual Bakual - change - 29 Aug 2017
Status New Pending
avatar C-Lodder C-Lodder - test_item - 29 Aug 2017 - Tested successfully
avatar C-Lodder
C-Lodder - comment - 29 Aug 2017

I have tested this item successfully on 21cd31f


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17756.

avatar franz-wohlkoenig franz-wohlkoenig - change - 29 Aug 2017
Category com_search Layout
avatar brianteeman brianteeman - test_item - 30 Aug 2017 - Tested successfully
avatar brianteeman
brianteeman - comment - 30 Aug 2017

I have tested this item successfully on 21cd31f

tested on ie11 - confirmed issue and this pr resolves it


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17756.

avatar franz-wohlkoenig franz-wohlkoenig - change - 30 Aug 2017
Status Pending Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 30 Aug 2017

RTC after two successful tests.

avatar dgt41
dgt41 - comment - 30 Aug 2017

@franz-wohlkoenig I would expect a successful test with IE8 before elevating the status to RTC

avatar franz-wohlkoenig franz-wohlkoenig - change - 30 Aug 2017
Status Ready to Commit Pending
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 30 Aug 2017

Status set back on "Pending".

avatar C-Lodder
C-Lodder - comment - 30 Aug 2017

@dgt41 already tested on IE8 (I should have mentioned). Working fine

avatar dgt41 dgt41 - change - 30 Aug 2017
Status Pending Ready to Commit
avatar dgt41
dgt41 - comment - 30 Aug 2017

RTC then

avatar joomla-cms-bot joomla-cms-bot - change - 31 Aug 2017
Category com_search Layout
avatar wilsonge wilsonge - change - 31 Aug 2017
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-08-31 10:04:34
Closed_By wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 31 Aug 2017
avatar wilsonge wilsonge - merge - 31 Aug 2017

Add a Comment

Login with GitHub to post a comment