Feeling Lucky
?
?
?
[#17750] - [4.0] Update error renderers for PHP 7 code structure, update Exception/Throwable references
- Fixed in Code Base
- 29 Aug 2017
- Medium
- Build: 4.0-dev
- # 17750
- Diff
- mbabker:throwable
User tests: Successful: Unsuccessful:
Summary of Changes
- Updates the new error handling library to use PHP 7 typing features (typehint
Throwable, scalar typehints, return types) - Removes the protected
doRendermethod in the error handling library, only existed to allow the interface'srender()method handle type checking that we can now handle with the method signature alone - Adds the
Throwabletypehint to methods we register as a global Exception handler viaset_exception_handler()and removes the internal type checking - Removes checks for the base
Exceptionclass when also checking for theThrowableinterface, we only need to check the interface in these locations
Testing Instructions
- Error handling code still processes correctly
Documentation Changes Required
The Joomla\CMS\Exception\ExceptionHandler::render() signature is changed to include the Throwable typehint. Before 3.5 when PHP 7 support was added this was typehinted as Exception. As this method normally shouldn't be directly called except for code which is already handling a Throwable object, this should be a minimal impact change.
joomla-cms-bot
- | Category | ⇒ | Installation Libraries Front End Plugins Unit Tests |
| Status | New | ⇒ | Pending |
wilsonge
- | Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-08-29 10:25:18 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
?
?
|
||