[#17734] - Color of the error message (Admin-menu)
- Closed
- 31 Aug 2017
- Medium
- Build: staging
- # 17734
- Diff
- akritianand:staging
User tests: Successful: Unsuccessful:
Pull Request for Issue #17729.
Summary of Changes
Color of the error message after attempting to delete a Admin-menu - SOLVED
Changed 'alert-success' to 'alert-danger' in line 14
joomla-cms-bot
- | Category | ⇒ | Administration Templates (admin) |
| Status | New | ⇒ | Pending |
| Labels |
Added:
?
|
||
I have tested this item
Applying PR in Patchtester got red Message "Patch successfully applied" as it is usually green:
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17734.
This is obviously not correct as it changes all messages
You need to change type of that specific alerts. What you PR does it change all default (message) alerts to red.
I am so sorry. I'll correct it ASAP.
The code is in 2 places.
It uses setError()
https://github.com/joomla/joomla-cms/blob/staging/libraries/src/Table/MenuType.php#L195
https://github.com/joomla/joomla-cms/blob/staging/libraries/src/Table/MenuType.php#L212
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-08-31 07:29:13 |
| Closed_By | ⇒ | akritianand |
@akritianand test own Pull Request don't count as it is expected that Dev. test PR before send on Github.