? Pending

User tests: Successful: Unsuccessful:

avatar alikon
alikon
27 Aug 2017

Pull Request for Issue #17731 .

Summary of Changes

fix total check

Testing Instructions

see #17731

Expected result

no warning

Actual result

waring

avatar joomla-cms-bot joomla-cms-bot - change - 27 Aug 2017
Category Front End com_finder
avatar alikon alikon - open - 27 Aug 2017
avatar alikon alikon - change - 27 Aug 2017
Status New Pending
avatar franz-wohlkoenig franz-wohlkoenig - test_item - 27 Aug 2017 - Tested successfully
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 27 Aug 2017

I have tested this item successfully on 1a744e7


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17732.

avatar franz-wohlkoenig franz-wohlkoenig - change - 27 Aug 2017
Easy No Yes
avatar sandewt
sandewt - comment - 27 Aug 2017

Hi @alikon,

What do you think of:

<?php if ($this->total === 0 || $this->total === null) : ?>

Instead of:

<?php if (($this->total === 0) || ($this->total === null)) : ?>

In line 36, file ..\components\com_finder\views\search\tmpl\default_results.php ???

Gr.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17732.

avatar sandewt sandewt - test_item - 27 Aug 2017 - Tested successfully
avatar sandewt
sandewt - comment - 27 Aug 2017

I have tested this item successfully on 1a744e7

See note above.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17732.

avatar franz-wohlkoenig franz-wohlkoenig - change - 27 Aug 2017
Status Pending Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 27 Aug 2017

RTC after two successful tests.

avatar mbabker mbabker - change - 27 Aug 2017
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-08-27 16:10:18
Closed_By mbabker
Labels Added: ?
avatar mbabker mbabker - close - 27 Aug 2017
avatar mbabker mbabker - merge - 27 Aug 2017

Add a Comment

Login with GitHub to post a comment