Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#17730] - tag observer dirty fix

Pending

User tests: Successful: Unsuccessful:

avatar alikon
alikon
27 Aug 2017

Pull Request for Issue #17710 .

Summary of Changes

tag observer dirty fix
i'm sure it can be done in a more clean way

Testing Instructions

In the article manager, try to batch assign a tag to an article

Expected result

batch process complete

Actual result

Call to a member function setNewTags() on null

Documentation Changes Required

avatar joomla-cms-bot joomla-cms-bot - change - 27 Aug 2017
Category ⇒ Administration com_categories Libraries
avatar alikon alikon - open - 27 Aug 2017
avatar alikon alikon - change - 27 Aug 2017
Status New ⇒ Pending
avatar franz-wohlkoenig franz-wohlkoenig - test_item - 27 Aug 2017 - Tested successfully
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 27 Aug 2017

I have tested this item ✅ successfully on e40ae2d

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17730.

avatar franz-wohlkoenig franz-wohlkoenig - change - 27 Aug 2017
Easy No ⇒ Yes
avatar Bakual
Bakual - comment - 27 Aug 2017

@laoneo Looking at the code, this looks to me like a missing class mapping.

avatar mbabker
mbabker - comment - 27 Aug 2017

The mapping's there...

joomla-cms/libraries/classmap.php

Line 72 in aafbe7d

JLoader::registerAlias('JTableObserverTags', '\\Joomla\\CMS\\Table\\Observer\\Tags', '5.0');

Maybe the leading slash in the namespaced code is the issue?

avatar laoneo
laoneo - comment - 28 Aug 2017

The problem is that the observer doesn't support class alias. I made a new pr with the correct fix to be again BC. Please test pr #17739 which should fix the issue globally.
I would close this pr as it doesn't fix the cause of the issue.

avatar alikon
alikon - comment - 28 Aug 2017

closing in favor of #17739

avatar alikon alikon - change - 28 Aug 2017
Status Pending ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2017-08-28 07:53:12
Closed_By ⇒ alikon
avatar alikon alikon - close - 28 Aug 2017

Add a Comment

Login with GitHub to post a comment